Bug 1302

Summary:	dpdk-pcapdump regression
Product:	DPDK	Reporter:	nick.hedberg
Component:	other	Assignee:	Stephen Hemminger (stephen)
Status:	UNCONFIRMED ---
Severity:	normal	CC:	david.marchand, thomas
Priority:	Normal
Version:	23.03
Target Milestone:	---
Hardware:	x86
OS:	Linux
Attachments:	testpmd output for the two commits dumpcap output for two commits

Description nick.hedberg 2023-10-19 13:12:48 CEST

Created attachment 262 [details]
testpmd output for the two commits

Commit 6026bfa breaks dumpcap on CX6 DX, the previous commit. 742be6a, didn't show this issue. 
The error with this commit is: 
> ~/dpdk/build-6026bfa$ sudo ./app/dpdk-testpmd -c 0xf0 -n 4 -a 0000:03:00.0 --
> -i --port-topology=chained
...
> testpmd> start
> Packet forwarding already started
> testpmd> pdump_register_rx_callbacks(): rx callback for port=0 queue=0,
> already exists

and: 

>~/dpdk/build-6026bfa$ sudo ./app/dpdk-dumpcap -i 0  -c 6 -i 0 -w
>/tmp/sample.pcapng
File: /tmp/sample.pcapng
>pdump_prepare_client_request(): client request for pdump enable/disable failed
>EAL: Error - exiting with code: 1
>  Cause: Packet dump enable on 0:0000:03:00.0 failed Operation not permitted

Comment 1 nick.hedberg 2023-10-19 13:13:21 CEST

Created attachment 263 [details]
dumpcap output for two commits

Comment 2 Stephen Hemminger 2023-10-19 17:04:22 CEST

Looks like there were errors in setup even before the commit you are targeting.
Some of the devices probed could not be used. Looks like old code would ignore the error and keep going.

Comment 3 Stephen Hemminger 2023-10-20 23:50:00 CEST

If secondary process has errors during probing then it should exit right after init, and not even try and enable pdump