Bug 1331

Summary: net/ice: driver logs an error level message about QinQ support
Product: DPDK Reporter: David Marchand (david.marchand)
Component: otherAssignee: qi.z.zhang (qi.z.zhang)
Status: UNCONFIRMED ---    
Severity: major CC: david.marchand, john.mcnamara
Priority: Normal    
Version: 23.07   
Target Milestone: ---   
Hardware: All   
OS: All   

Description David Marchand 2023-12-01 15:24:02 CET
This has been noticed with OVS which refuses any error log level in basic sanity checks.

This can be easily reproduced with a E810 nic and "default" ddp files.
On a RHEL8 for example, with:

# find /lib/firmware/intel/ice/ddp* ! -type d -exec ls -l {} \;
lrwxrwxrwx. 1 root root 16 Sep 27 14:09 /lib/firmware/intel/ice/ddp/ice.pkg -> ice-1.3.30.0.pkg
-rw-r--r--. 1 root root 692660 Sep 27 14:09 /lib/firmware/intel/ice/ddp/ice-1.3.30.0.pkg
-rw-r--r--. 1 root root 725428 Sep 27 14:09 /lib/firmware/intel/ice/ddp-comms/ice_comms-1.3.40.0.pkg
-rw-r--r--. 1 root root 692776 Sep 27 14:09 /lib/firmware/intel/ice/ddp-lag/ice_lag-1.3.1.0.pkg
-rw-r--r--. 1 root root 725428 Sep 27 14:09 /lib/firmware/intel/ice/ddp-wireless_edge/ice_wireless_edge-1.3.10.0.pkg


# dpdk-testpmd -a 0000:04:00.0 --log-level=pmd.net.*:error -- -i
EAL: Detected CPU lcores: 56
EAL: Detected NUMA nodes: 2
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: VFIO support initialized
EAL: Using IOMMU type 1 (Type 1)
EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:04:00.0 (socket 0)
TELEMETRY: No legacy callbacks, legacy socket not created
Interactive-mode selected
testpmd: create a new mbuf pool <mb_pool_0>: n=171456, size=2176, socket=0
testpmd: preferred mempool ops selected: ring_mp_mc
testpmd: create a new mbuf pool <mb_pool_1>: n=171456, size=2176, socket=1
testpmd: preferred mempool ops selected: ring_mp_mc

Warning! port-topology=paired and odd forward ports number, the last port will pair with itself.

Configuring Port 0 (socket 0)
ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not support qinq
Port 0: 50:7C:6F:3C:0C:26
Checking link statuses...
Done
testpmd> 


This error log makes no sense: no QinQ support has been requested.

The commit that introduced it is: de5da9d16430 ("net/ice: support double VLAN")