Bug 593

Summary:	dpaa2 PMD APIs is missing input validation
Product:	DPDK	Reporter:	Ferruh YIGIT (ferruh.yigit)
Component:	ethdev	Assignee:	Hemant Agrawal (hemant.agrawal)
Status:	UNCONFIRMED ---
Severity:	normal	CC:	ajit.khaparde
Priority:	Normal
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All

Description Ferruh YIGIT 2020-12-04 17:17:31 CET

1)
struct rte_flow *
rte_pmd_dpaa2_mux_flow_create(uint32_t dpdmux_id,
                              struct rte_flow_item *pattern[],
                              struct rte_flow_action *actions[])

'- 'pattern' & 'actions' & 'pattern[0]' & 'actions[0]', should be checked against NULL before using them


2)
int
rte_pmd_dpaa2_set_custom_hash(uint16_t port_id,
                              uint16_t offset,
                              uint8_t size)

- 'port_id' should be checked if it is valid and if it is 'dpaa2' port or not

Comment 1 Ajit Khaparde 2021-03-09 05:06:38 CET

Hemant, please take a look. Thanks

Comment 2 Hemant Agrawal 2021-03-09 06:32:50 CET

Thanks. we will fix it.