Bug 890
Summary: | lib/ip_frag: IPv4 options without copied bit set are present in all fragments | ||
---|---|---|---|
Product: | DPDK | Reporter: | Dariusz Sosnowski (dsosnowski) |
Component: | other | Assignee: | dev |
Status: | UNCONFIRMED --- | ||
Severity: | minor | CC: | david.marchand |
Priority: | Normal | ||
Version: | 21.11 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
Dariusz Sosnowski
2021-11-26 13:03:51 CET
Can you clarify, is this a regression in 21.11 when compared to previous versions? There was a proposal for handling IPv4 options, see: https://patchwork.dpdk.org/project/dpdk/patch/1637743626-70632-1-git-send-email-chcchc88@163.com/ No, this behaviour exists in previous versions as well. From what I see, before 21.05 the IPv4 options were never copied. http://patches.dpdk.org/project/dpdk/patch/tencent_8FA596830F4F89E9E2169503B40DF0FF0307@qq.com/ introduced copying options to each fragment to 21.05. I quickly went through the patch you mentioned and it is a step in the right direction and should fix the issue. However, with this patch, IPv4 options not meant to be copied will be substituted by NOOP option and in effect this reduces maximum datagram size for the following fragments. I am not sure if this is desirable in this case. Please share your concerns on the mailing list by replying to this patch. |