Bug 923

Summary:	i40e PMD contains copy-pasted bug from mempool library
Product:	DPDK	Reporter:	Morten Brørup (mb)
Component:	ethdev	Assignee:	dev
Status:	RESOLVED DUPLICATE
Severity:	normal
Priority:	Normal
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All

Description Morten Brørup 2022-01-20 09:43:28 CET

The mempool library does not flush its cache correctly, but leaves it full after flushing.
This bug is fixed in [1], but remains in the i40e PMD, which contains copy-pasted code [2] from the mempool library.

Other PMDs with copy-pasted code may have the same bug.

[1]
http://inbox.dpdk.org/dev/20220119150301.42583-1-mb@smartsharesystems.com/T/#u

[2]
http://code.dpdk.org/dpdk/latest/source/drivers/net/i40e/i40e_rxtx_vec_avx512.c#L919

Comment 1 Morten Brørup 2022-07-14 17:46:42 CEST

Copy-pasting internal code and not using the mempool API causes more problems than just the risk of spreading bugs from the library it is copied from to the destinations where it is copied.

*** This bug has been marked as a duplicate of bug 1052 ***