Bug 958
Summary: | Most drivers are silently ignoring 'has_vlan' rte_flow match criteria | ||
---|---|---|---|
Product: | DPDK | Reporter: | Ilya Maximets (i.maximets) |
Component: | ethdev | Assignee: | Thomas Monjalon (thomas) |
Status: | CONFIRMED --- | ||
Severity: | major | CC: | admin, david.marchand, kaiwenx.deng, orika |
Priority: | Normal | ||
Version: | 21.11 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
Ilya Maximets
2022-03-15 21:01:57 CET
Please could you send a patch to mark drivers with partial support? It would be a good first step before aligning them with has_vlan support. About the deprecation, it is a separate topic which deserves a separate bug or mail. I agree some cleanup should be done in rte_flow in general. Let's use this bug ID to track the support of has_vlan in drivers. (In reply to Thomas Monjalon from comment #1) > Please could you send a patch to mark drivers with partial support? > It would be a good first step before aligning them with has_vlan support. OK. Posted: https://patches.dpdk.org/project/dpdk/patch/20220316120157.390311-1-i.maximets@ovn.org/ While making the patch I found that cnxk currently supports the flag, and I also found that vlan item has to be marked the same way because of the 'has_more_vlan' flag. Thanks. I would like to merge this patch after 22.03 release, so we can start discussing how to align all drivers. Any progress on this topic? Hi All, No reply for a long time, I'm going to close this ticket for now, so please contact me if you still have questions. Thanks Kaiwen Deng The RESOLVED FIXED is definitely a wrong status for this one as it is not fixed. And it is still an issue, so IMHO the bug should stay open. It also looks like the issue regressed and now NFP driver claims to support both ETH and VLAN items, while I can't find actual use of has_vlan or has_more_vlan in the driver code outside of the check that is designed to accept items with these fields set. So, it explicitly accepts them, but fully ignores... |