diff mbox

[dpdk-dev,v7,1/5] doc: remove RSS configuration change announcement

Message ID 20180423121635.32347-2-xuemingl@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Xueming Li April 23, 2018, 12:16 p.m. UTC 
  Remove deprecation as implementation of RSS level provided in Adrien's
patch set: http://www.dpdk.org/dev/patchwork/patch/37399/

Signed-off-by: Xueming Li <xuemingl@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/deprecation.rst | 4 ----
 1 file changed, 4 deletions(-)

Comments

Ferruh Yigit April 23, 2018, 4:13 p.m. UTC | #1 
On 4/23/2018 1:16 PM, Xueming Li wrote:
> Remove deprecation as implementation of RSS level provided in Adrien's
> patch set: http://www.dpdk.org/dev/patchwork/patch/37399/

Why deprecation notice removed in this set if the implementation is in other
set, or am I missing something?

> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 93747bf24..aba50b8ec 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -86,10 +86,6 @@ Deprecation Notices
>    Target release for removal of the legacy API will be defined once most
>    PMDs have switched to rte_flow.
>  
> -* ethdev: A new rss level field planned in 18.05.
> -  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a choice
> -  of RSS hash calculation on outer or inner header of tunneled packet.
> -
>  * ethdev: A work is being planned for 18.05 to expose VF port representors
>    as a mean to perform control and data path operation on the different VFs.
>    As VF representor is an ethdev port, new fields are needed in order to map
>
Thomas Monjalon April 23, 2018, 4:56 p.m. UTC | #2 
23/04/2018 18:13, Ferruh Yigit:
> On 4/23/2018 1:16 PM, Xueming Li wrote:
> > Remove deprecation as implementation of RSS level provided in Adrien's
> > patch set: http://www.dpdk.org/dev/patchwork/patch/37399/
> 
> Why deprecation notice removed in this set if the implementation is in other
> set, or am I missing something?

If I remember well, Adrien is implementing with rte_flow,
while the deprecation notice was for a different solution
(legacy ethdev config).

> > -* ethdev: A new rss level field planned in 18.05.
> > -  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a choice
> > -  of RSS hash calculation on outer or inner header of tunneled packet.
Xueming Li April 24, 2018, 5:07 a.m. UTC | #3 
Hi Ferruh,

> -----Original Message-----

> From: Ferruh Yigit <ferruh.yigit@intel.com>

> Sent: Tuesday, April 24, 2018 12:13 AM

> To: Xueming(Steven) Li <xuemingl@mellanox.com>; Wenzhuo Lu <wenzhuo.lu@intel.com>; Jingjing Wu

> <jingjing.wu@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Adrien Mazarguil

> <adrien.mazarguil@6wind.com>

> Cc: Nélio Laranjeiro <nelio.laranjeiro@6wind.com>; Shahaf Shuler <shahafs@mellanox.com>; dev@dpdk.org;

> Olivier Matz <olivier.matz@6wind.com>

> Subject: Re: [dpdk-dev] [PATCH v7 1/5] doc: remove RSS configuration change announcement

> 

> On 4/23/2018 1:16 PM, Xueming Li wrote:

> > Remove deprecation as implementation of RSS level provided in Adrien's

> > patch set:

> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.

> > dpdk.org%2Fdev%2Fpatchwork%2Fpatch%2F37399%2F&data=02%7C01%7Cxuemingl%

> > 40mellanox.com%7Ca192c13afbc2417d134a08d5a9351b49%7Ca652971c7d2e4d9ba6

> > a4d149256f461b%7C0%7C0%7C636600967922421810&sdata=cm0AJh7XXCnOOaFRGwhp

> > WR1D0HlHUNCyddrCXwPwFDQ%3D&reserved=0

> 

> Why deprecation notice removed in this set if the implementation is in other set, or am I missing

> something?


There was a plan to support rss level in this patch set, while Adrien provided a better implementation
with his own deprecation notice. That's why I remove my deprecation here.

> 

> >

> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>

> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

> > Acked-by: Thomas Monjalon <thomas@monjalon.net>

> > ---

> >  doc/guides/rel_notes/deprecation.rst | 4 ----

> >  1 file changed, 4 deletions(-)

> >

> > diff --git a/doc/guides/rel_notes/deprecation.rst

> > b/doc/guides/rel_notes/deprecation.rst

> > index 93747bf24..aba50b8ec 100644

> > --- a/doc/guides/rel_notes/deprecation.rst

> > +++ b/doc/guides/rel_notes/deprecation.rst

> > @@ -86,10 +86,6 @@ Deprecation Notices

> >    Target release for removal of the legacy API will be defined once most

> >    PMDs have switched to rte_flow.

> >

> > -* ethdev: A new rss level field planned in 18.05.

> > -  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a

> > choice

> > -  of RSS hash calculation on outer or inner header of tunneled packet.

> > -

> >  * ethdev: A work is being planned for 18.05 to expose VF port representors

> >    as a mean to perform control and data path operation on the different VFs.

> >    As VF representor is an ethdev port, new fields are needed in order

> > to map

> >
Ferruh Yigit April 25, 2018, 5:38 p.m. UTC | #4 
On 4/24/2018 6:07 AM, Xueming(Steven) Li wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Tuesday, April 24, 2018 12:13 AM
>> To: Xueming(Steven) Li <xuemingl@mellanox.com>; Wenzhuo Lu <wenzhuo.lu@intel.com>; Jingjing Wu
>> <jingjing.wu@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Adrien Mazarguil
>> <adrien.mazarguil@6wind.com>
>> Cc: Nélio Laranjeiro <nelio.laranjeiro@6wind.com>; Shahaf Shuler <shahafs@mellanox.com>; dev@dpdk.org;
>> Olivier Matz <olivier.matz@6wind.com>
>> Subject: Re: [dpdk-dev] [PATCH v7 1/5] doc: remove RSS configuration change announcement
>>
>> On 4/23/2018 1:16 PM, Xueming Li wrote:
>>> Remove deprecation as implementation of RSS level provided in Adrien's
>>> patch set:
>>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
>>> dpdk.org%2Fdev%2Fpatchwork%2Fpatch%2F37399%2F&data=02%7C01%7Cxuemingl%
>>> 40mellanox.com%7Ca192c13afbc2417d134a08d5a9351b49%7Ca652971c7d2e4d9ba6
>>> a4d149256f461b%7C0%7C0%7C636600967922421810&sdata=cm0AJh7XXCnOOaFRGwhp
>>> WR1D0HlHUNCyddrCXwPwFDQ%3D&reserved=0
>>
>> Why deprecation notice removed in this set if the implementation is in other set, or am I missing
>> something?
> 
> There was a plan to support rss level in this patch set, while Adrien provided a better implementation
> with his own deprecation notice. That's why I remove my deprecation here.

Deprecation notice updated in Adrien's set [1], will drop this patch from set
while applying.

[1]
https://dpdk.org/dev/patchwork/patch/38933/

> 
>>
>>>
>>> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
>>> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>>  doc/guides/rel_notes/deprecation.rst | 4 ----
>>>  1 file changed, 4 deletions(-)
>>>
>>> diff --git a/doc/guides/rel_notes/deprecation.rst
>>> b/doc/guides/rel_notes/deprecation.rst
>>> index 93747bf24..aba50b8ec 100644
>>> --- a/doc/guides/rel_notes/deprecation.rst
>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>> @@ -86,10 +86,6 @@ Deprecation Notices
>>>    Target release for removal of the legacy API will be defined once most
>>>    PMDs have switched to rte_flow.
>>>
>>> -* ethdev: A new rss level field planned in 18.05.
>>> -  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a
>>> choice
>>> -  of RSS hash calculation on outer or inner header of tunneled packet.
>>> -
>>>  * ethdev: A work is being planned for 18.05 to expose VF port representors
>>>    as a mean to perform control and data path operation on the different VFs.
>>>    As VF representor is an ethdev port, new fields are needed in order
>>> to map
>>>
>
diff mbox

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 93747bf24..aba50b8ec 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -86,10 +86,6 @@  Deprecation Notices
   Target release for removal of the legacy API will be defined once most
   PMDs have switched to rte_flow.
 
-* ethdev: A new rss level field planned in 18.05.
-  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a choice
-  of RSS hash calculation on outer or inner header of tunneled packet.
-
 * ethdev: A work is being planned for 18.05 to expose VF port representors
   as a mean to perform control and data path operation on the different VFs.
   As VF representor is an ethdev port, new fields are needed in order to map