[dpdk-dev,v6,11/11] doc: update mlx5 guide on tunnel offloading

Message ID 20180423123310.32991-12-xuemingl@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Shahaf Shuler
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Xueming Li April 23, 2018, 12:33 p.m. UTC
  Remove tunnel limitations, add new hardware tunnel offload features.

Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
 doc/guides/nics/features/default.ini | 1 +
 doc/guides/nics/features/mlx5.ini    | 3 +++
 doc/guides/nics/mlx5.rst             | 4 ++--
 3 files changed, 6 insertions(+), 2 deletions(-)
  

Comments

Ferruh Yigit April 26, 2018, 11 a.m. UTC | #1
On 4/23/2018 1:33 PM, Xueming Li wrote:
> Remove tunnel limitations, add new hardware tunnel offload features.
> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
>  doc/guides/nics/features/default.ini | 1 +
>  doc/guides/nics/features/mlx5.ini    | 3 +++
>  doc/guides/nics/mlx5.rst             | 4 ++--
>  3 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
> index dae2ad776..49be81450 100644
> --- a/doc/guides/nics/features/default.ini
> +++ b/doc/guides/nics/features/default.ini
> @@ -29,6 +29,7 @@ Multicast MAC filter =
>  RSS hash             =
>  RSS key update       =
>  RSS reta update      =
> +Inner RSS            =
>  VMDq                 =
>  SR-IOV               =
>  DCB                  =

When a new feature added, it need to be documented, in doc/guides/nics/features.rst.

To not block this set, can you please send an incremental patch for this?
  
Xueming Li April 26, 2018, 2:03 p.m. UTC | #2
Hi Ferruh,

Thanks for reminding, new patch sent:
http://www.dpdk.org/dev/patchwork/patch/39026/

Best Regards,
Xueming

> -----Original Message-----

> From: Ferruh Yigit <ferruh.yigit@intel.com>

> Sent: Thursday, April 26, 2018 7:00 PM

> To: Xueming(Steven) Li <xuemingl@mellanox.com>; Nélio Laranjeiro <nelio.laranjeiro@6wind.com>; Shahaf

> Shuler <shahafs@mellanox.com>

> Cc: dev@dpdk.org

> Subject: Re: [dpdk-dev] [PATCH v6 11/11] doc: update mlx5 guide on tunnel offloading

> 

> On 4/23/2018 1:33 PM, Xueming Li wrote:

> > Remove tunnel limitations, add new hardware tunnel offload features.

> >

> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>

> > ---

> >  doc/guides/nics/features/default.ini | 1 +

> >  doc/guides/nics/features/mlx5.ini    | 3 +++

> >  doc/guides/nics/mlx5.rst             | 4 ++--

> >  3 files changed, 6 insertions(+), 2 deletions(-)

> >

> > diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini

> > index dae2ad776..49be81450 100644

> > --- a/doc/guides/nics/features/default.ini

> > +++ b/doc/guides/nics/features/default.ini

> > @@ -29,6 +29,7 @@ Multicast MAC filter =

> >  RSS hash             =

> >  RSS key update       =

> >  RSS reta update      =

> > +Inner RSS            =

> >  VMDq                 =

> >  SR-IOV               =

> >  DCB                  =

> 

> When a new feature added, it need to be documented, in doc/guides/nics/features.rst.

> 

> To not block this set, can you please send an incremental patch for this?
  

Patch

diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index dae2ad776..49be81450 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -29,6 +29,7 @@  Multicast MAC filter =
 RSS hash             =
 RSS key update       =
 RSS reta update      =
+Inner RSS            =
 VMDq                 =
 SR-IOV               =
 DCB                  =
diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini
index f8ce08770..e75b14bdc 100644
--- a/doc/guides/nics/features/mlx5.ini
+++ b/doc/guides/nics/features/mlx5.ini
@@ -21,6 +21,7 @@  Multicast MAC filter = Y
 RSS hash             = Y
 RSS key update       = Y
 RSS reta update      = Y
+Inner RSS            = Y
 SR-IOV               = Y
 VLAN filter          = Y
 Flow director        = Y
@@ -30,6 +31,8 @@  VLAN offload         = Y
 L3 checksum offload  = Y
 L4 checksum offload  = Y
 Timestamp offload    = Y
+Inner L3 checksum    = Y
+Inner L4 checksum    = Y
 Packet type parsing  = Y
 Rx descriptor status = Y
 Tx descriptor status = Y
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 6b83759c8..ef1c7da45 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -74,12 +74,12 @@  Features
 - RX interrupts.
 - Statistics query including Basic, Extended and per queue.
 - Rx HW timestamp.
+- Tunnel types: VXLAN, L3 VXLAN, VXLAN-GPE, GRE, MPLS-in-GRE, MPLS-in-UDP.
+- Tunnel HW offloads: packet type, inner/outer RSS, IP and UDP checksum verification.
 
 Limitations
 -----------
 
-- Inner RSS for VXLAN frames is not supported yet.
-- Hardware checksum RX offloads for VXLAN inner header are not supported yet.
 - For secondary process:
 
   - Forked secondary process not supported.