[dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

Pavan Nikhilesh Bhagavatula pbhagavatula at caviumnetworks.com
Tue Nov 21 15:04:53 CET 2017


On Tue, Nov 21, 2017 at 02:30:48PM +0100, Thomas Monjalon wrote:
> 21/11/2017 12:14, Pavan Nikhilesh Bhagavatula:
> > On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote:
> > > 20/11/2017 19:40, Ferruh Yigit:
<snip>
> >
> > I will be sending out the patch set soon.
>
> These are only the legacy static log types.
> Are you sure you want to change them?
> They should be removed when using dynamic logging.

Actually this same struct is used for registering dynamic logs for legacy
modules currently,

/* register legacy log types */
for (i = 0; i < RTE_DIM(logtype_strings); i++)
	__rte_log_register(logtype_strings[i].logtype,
		logtype_strings[i].log_id);

I have just prefixed them with "lib.". If we remove this form here then each
module has to use constructor style initialisation for logs which would be a
lot of rework.


More information about the dev mailing list