[dpdk-dev] [PATCH] bus/fslmc: use PRIu64 instead of llX in format specifier

Shreyansh Jain shreyansh.jain at nxp.com
Fri Apr 13 10:56:24 CEST 2018


On Friday 13 April 2018 01:11 PM, Thomas Monjalon wrote:
> 13/04/2018 07:04, Gowrishankar:
>> -	DPAA2_BUS_DEBUG("--> Map address: %llX, size: 0x%llX",
>> +	DPAA2_BUS_DEBUG("--> Map address: %"PRIu64", size: 0x%"PRIu64"",
> 
> You cannot replace hexadecimal by decimal.
> You need to use PRIx64.
> 
> 

Now that Thomas has pointed out, I think the log message can be 
improved. Len as hex is not helpful and is out of sync with other 
messages in this file.

While on this, I think it should be corrected.
I will fix this.

@gowrishankar, I will post a patch in reply to your patch - can you 
please help me with ppc64le check? I will take care of Hemant's comment.

-
Shreyansh


More information about the dev mailing list