[dpdk-dev] [PATCH 1/3] examples/l3fwd: convert to SPDX license tags

[Gavin Hu]

On 18 May 2018 at 16:17, Ferruh Yigit <ferruh.yigit at intel.com> wrote:

> On 4/19/2018 9:52 AM, gavin.hu at linaro.org wrote:
> > From: Gavin Hu <gavin.hu at linaro.org>
> >
> > Signed-off-by: Gavin Hu <gavin.hu at linaro.org>
>
> <...>
>
> > diff --git a/examples/l3fwd/l3fwd_common.h
> b/examples/l3fwd/l3fwd_common.h
> > index 7002a43..df3e461 100644
> > --- a/examples/l3fwd/l3fwd_common.h
> > +++ b/examples/l3fwd/l3fwd_common.h
> > @@ -1,35 +1,6 @@
> > -/*-
> > - *   BSD LICENSE
> > - *
> > - *   Copyright(c) 2016 Intel Corporation. All rights reserved.
> > - *   Copyright(c) 2017, Linaro Limited
> > - *   All rights reserved.
> > - *
> > - *   Redistribution and use in source and binary forms, with or without
> > - *   modification, are permitted provided that the following conditions
> > - *   are met:
> > - *
> > - *     * Redistributions of source code must retain the above copyright
> > - *       notice, this list of conditions and the following disclaimer.
> > - *     * Redistributions in binary form must reproduce the above
> copyright
> > - *       notice, this list of conditions and the following disclaimer in
> > - *       the documentation and/or other materials provided with the
> > - *       distribution.
> > - *     * Neither the name of Intel Corporation nor the names of its
> > - *       contributors may be used to endorse or promote products derived
> > - *       from this software without specific prior written permission.
> > - *
> > - *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> > - *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> > - *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> FOR
> > - *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> COPYRIGHT
> > - *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> INCIDENTAL,
> > - *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> > - *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
> USE,
> > - *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
> ANY
> > - *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> > - *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
> USE
> > - *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(c) 2016 Intel Corporation. All rights reserved.
> > + * Copyright(c) 2018 Linaro Limited. All rights reserved.
> >   */
>
> You can drop " All rights reserved." note from Intel copyright line.
> Linaro ones
> are up to you.
>
> Linaro copyright seems updated, most probably you don't want to update when
> copyright starts but extend it like 2017-2018.
>
> Above two issue exists in other patches as well, can you please check them.
> And can you please keep Hemant's ack for next version of the patch?
>

Sure, I will re-work it, do I need to extend the copyright like 2017-2018
for intel copyright lines also to maintain consistency?


-- 

Best Regards,
Gavin Hu
www.linaro.org