Bug 14
Summary: | Kernel Crash bug of ixgbevf kernel module in "Intel(R) 10GbE PCI Express Virtual Function Driver Version: 4.0.3 Release: 1" and the latest version | ||
---|---|---|---|
Product: | DPDK | Reporter: | batmanustc |
Component: | other | Assignee: | batmanustc |
Status: | CONFIRMED --- | ||
Severity: | critical | CC: | ajit.khaparde, paul.m.stillwell.jr, qian.q.xu, qi.z.zhang |
Priority: | Normal | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Attachments: | vmcore-dmesg.txt |
Description
batmanustc
2018-02-02 03:43:43 CET
Looks like a ixgbevf/ixgbe kernel bug. What's your DPDK version and ixgbe kernel driver/firmware version? you can use ethtool -i device_id to check. Could you try newer kernel version, or you can check the link here for Tested platform in http://dpdk.org/doc/guides/rel_notes/ as reference. This is my patch: diff --git a/kmod/ixgbevf-4.0.3/src/ixgbevf_main.c b/kmod/ixgbevf-4.0.3/src/ixgbevf_main.c index 88f87cc..1373ab8 100644 --- a/kmod/ixgbevf-4.0.3/src/ixgbevf_main.c +++ b/kmod/ixgbevf-4.0.3/src/ixgbevf_main.c @@ -3742,9 +3742,14 @@ static int ixgbevf_close(struct net_device *netdev) { struct ixgbevf_adapter *adapter = netdev_priv(netdev); + while(test_and_set_bit(__IXGBEVF_SERVICE_SCHED, &adapter->state)) + msleep(1); + if (netif_device_present(netdev)) ixgbevf_close_suspend(adapter); + clear_bit(__IXGBEVF_SERVICE_SCHED, &adapter->state); + return 0; } Qian, Does the patch make sense? Or do you want to point the bug to someone else? Thanks Hi, If you would like your patch reviewed, please submit the patch to intel-wired-lan@lists.osuosl.org. Please attach the patch (since mailers sometimes mess with the spacing in code) as well as put it in the body of the message. Here are a couple of suggestions before you send the patch: 1. Make sure your patch description has adequate information about what the problem is and how this patch solves the problem. What you have above doesn't contain enough information about why this fixes the issue you are seeing. 2. Make sure your whitespace is correct. The patch above could be suffering from an artifact when posting to the web forum, but make sure that in the code the tabs are set correctly and that everything lines up with the code around it. 3. You can also include steps to reproduce the issue in the email. If you can reproduce without DPDK then that is the best path to take since anyone reviewing the patch on the above mailing list may not be able to reproduce with DPDK. 4. I noticed that your patch is based on 4.0.3 and the current version of the ixgbevf driver is 4.3.5, so you will probably get better support if you reproduce on the 4.3.5 version of the driver and then submit your patch based on that. Thanks! batmanustc@gmail.com Do you have any update? |