Bug 21
Summary: | Ixgbe driver changes FCTRL without first disabling RXCTRL.RXEN | ||
---|---|---|---|
Product: | DPDK | Reporter: | Solal Pirelli (solal.pirelli) |
Component: | ethdev | Assignee: | Konstantin Ananyev (konstantin.v.ananyev) |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | ajit.khaparde, wei.zhao1 |
Priority: | Normal | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
Solal Pirelli
2018-04-01 14:37:39 CEST
Read from datasheet, RXCTRL.RXEN indeed need to be disabled before promiscuous/multicast/Broadcast Accept configuration, but by now code don't do that and it seems no abnormal phenomenon for this operation. Konstantin, Please take a look and re-assign if necessary. (In reply to Solal Pirelli from comment #0) > The Intel 82599 data sheet > (https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/ > 82599-10-gbe-controller-datasheet.pdf, §8.2.3.7.1) states that "Before > receive filters are updated/modified the RXCTRL.RXEN bit should be set to > 0b. After the proper filters have been set the RXCTRL.RXEN bit can be set to > 1b to re-enable the receiver." > > However, the ixgbe driver's promiscuous and allmulticast enable/disable > functions edit the FCTRL filters without disabling (or at least checking) > RXCTRL.RXEN. (e.g. > http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/ixgbe_ethdev.c?h=v18. > 02#n4053) In principle, the code in base folder will not be changed if there is no bug or issue. By now, don't do that and it seems no abnormal phenomenon for this operation. So it is not a bug, and change state to resolve and wontfix. it is not a bug, and change state to resolve and wontfix. |