Bug 26

Summary:	Ixgbe driver does not ensure FWSM firmware mode is valid before using it
Product:	DPDK	Reporter:	Solal Pirelli (solal.pirelli)
Component:	ethdev	Assignee:	Konstantin Ananyev (konstantin.v.ananyev)
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	ajit.khaparde, Muthurajan.Jayakumar, stevex.yang
Priority:	Normal
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All

Description Solal Pirelli 2018-04-01 15:43:13 CEST

The Intel 82599 data sheet (https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82599-10-gbe-controller-datasheet.pdf, §8.2.3.4.10) states of the FWSM register's bit 15 (FW_Val_bit) that "Hardware clears this bit in reset de-assertion so software can know firmware mode (bits 1-5) is invalid".

However, the ixgbe driver does not check that bit before using the firmware mode, e.g. in ixgbe_mng_present (http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/base/ixgbe_common.c?h=v18.02#n5194).

Comment 1 Ajit Khaparde 2018-08-30 10:52:33 CEST

Konstantin, One more to check. Thanks

Comment 2 Steve Yang 2020-12-25 07:03:37 CET

ixgbe driver doesn’t do some bit check just like indicated in ixgbe data sheet before doing something, but not functional bugs. Looks like FW/HW is robust enough, nothing needs to be changed.