Bug 28
| Summary: | event/octeontx: snprintf() overflow | ||
|---|---|---|---|
| Product: | DPDK | Reporter: | Harry van Haaren (Intel) (harry.van.haaren) |
| Component: | eventdev | Assignee: | Pavan Nikhilesh (pbhagavatula) |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | pbhagavatula, thomas |
| Priority: | Normal | ||
| Version: | 18.05 | ||
| Target Milestone: | 18.05 | ||
| Hardware: | ARM | ||
| OS: | All | ||
| URL: | http://dpdk.org/commit/13573bd3 | ||
| Attachments: | Fix snprintf overflow | ||
Created attachment 5 [details]
Fix snprintf overflow
Thanks @Pavan, attached patch fixes here. Fix applied: http://dpdk.org/commit/13573bd3 |
Compiling latest git with Meson and GCC 5.4, it prints a warning for always overflowing a destination buffer. [1/15] Compiling C object 'drivers/tmp_rte_..._event@sta/event_octeontx_timvf_evdev.c.o' In file included from /usr/include/stdio.h:936:0, from ../lib/librte_eal/common/include/rte_log.h:21, from ../lib/librte_eal/common/include/rte_debug.h:17, from ../lib/librte_eal/common/include/generic/rte_cycles.h:16, from ../lib/librte_eal/common/include/arch/x86/rte_cycles.h:13, from ../drivers/event/octeontx/timvf_evdev.h:10, from ../drivers/event/octeontx/timvf_evdev.c:6: In function ‘snprintf’, inlined from ‘timvf_ring_create’ at ../drivers/event/octeontx/timvf_evdev.c:298:2: /usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: warning: call to __builtin___snprintf_chk will always overflow destination buffer return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, /* Declaration of pool_name */ char pool_name[25]; ... /* offending line, note the mismatch in size 25 and 30 */ snprintf(pool_name, 30, "timvf_chunk_pool%d", timr->tim_ring_id); Commited in f874c1eb1519185feba05a0542413492e5f56ae9