[dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent

[Bruce Richardson]

On Mon, Feb 02, 2015 at 11:39:18AM +0600, Yerden Zhumabekov wrote:
> 
> 02.02.2015 9:31, Neil Horman пишет:
> > On Mon, Feb 02, 2015 at 09:07:45AM +0600, Yerden Zhumabekov wrote:
> >
> >> I think so, I've just successfully built it against latest snapshot with
> >> RTE_TARGET
> >> equal to 'x86_64-native-linuxapp-gcc'.
> >>
> > Please confirm that setting the machine type to default builds and runs properly.
> 
> If I understood you correctly, I set CONFIG_RTE_MACHINE="default" in the
> config and the build was successful.
> 

Confirmed, this worked for me too.
Looking at the patches, they look good. However, one thing I think we are missing
is a unit test to verify that all our CRC implementations give the same result.
That would be useful as a sanity check of the software fallback especially. The
existing hash tests, test the hash table implementation rather than the
mathematical argorithm used to compute the hash values.

Overall, though, software fallback for CRC is something well worthwhile having.

Series Acked-by: Bruce Richardson <bruce.richardson at intel.com>

> -- 
> Sincerely,
> 
> Yerden Zhumabekov
> State Technical Service
> Astana, KZ
> 
>