[dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver framework for EAL

[Shreyansh Jain]

Hi David,

> -----Original Message-----
> From: Hunt, David [mailto:david.hunt at intel.com]
> Sent: Thursday, September 15, 2016 6:26 PM
> To: Shreyansh Jain <shreyansh.jain at nxp.com>; dev at dpdk.org
> Cc: viktorin at rehivetech.com; Hemant Agrawal <hemant.agrawal at nxp.com>
> Subject: Re: [dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver
> framework for EAL
> 
> Shreyansh, Jan, Hemant,
> 
> On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
> > Introduction:
> > =============
> >
> > This patch set is direct derivative of Jan's original series [1],[2].
> >
> >   - As this deviates substantially from original series, if need be I can
> >     post it as a separate patch rather than v2. Please suggest.
> >   - Also, there are comments on original v1 ([4]) which are _not_
> >     incorporated in this series as they refer to section no more in new
> >     version.
> >   - This v3 version is based on the rte_driver/device patchset v9 [10].
> >     That series introduced device structures (rte_driver/rte_device)
> >     generalizing devices into PCI, VDEV, XXX. For the purpose of this
> >     patchset, XXX=>SOC.
> >
> >
> ---snip---
> 
>      FYI, I've reviewed this patch set, and it looks to me like there's
> some very good work here. Each patch in the set builds nicely on the one
> before, and logically introduces the changes one by one.

Great. Thank you so much for reviewing this series. It would really help us move it ahead and introduce other series which are based on it.

> 
>     I've no functional suggestions as the implementation looks clean,
> but I've one or two tiny suggestions on headers and error messages. I'll
> add a reply to the relevant patches in the set.

I will have a look at those and fix them soon (v4). 

> 
> Also, there's one or two issues thrown up by checkpatch, but I suspect
> they're false positives, as I'm using the 4.6 kernel version.

Thanks for headup - I will see/fix those in v4, if any. 


> 
> Regards,
> Dave
> 

-
Shreyansh