[dpdk-dev] [PATCH 1/2] i40e: Add packet_type metadata in the i40e vPMD

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Sep 23 10:23:16 CEST 2016


2016-09-23 06:40, Zhang, Qi Z:
> > From: Damjan Marion <damarion at cisco.com>
> > 
> > The ptype is decoded from the rx descriptor and stored in the packet type field
> > in the mbuf using the same function as the non-vector driver.
> > 
> > Signed-off-by: Damjan Marion <damarion at cisco.com>
> > Signed-off-by: Jeff Shaw <jeffrey.b.shaw at intel.com>
> 
> Acted-by: Zhang Qi <qi.z.zhang at intel.com>

It should be Acked-by :)

Just a note about name convention:
In DPDK we use the english naming style which is to put the first name
first and the surname last.
I believe your surname is Zhang so maybe you should write:
	Acked-by: Qi Zhang <qi.z.zhang at intel.com>

By the way, thanks for reviewing.


More information about the dev mailing list