[dpdk-dev] [PATCH v7 0/2] clean up interrupt handle

Qi Zhang qi.z.zhang at intel.com
Thu Apr 6 14:42:20 CEST 2017


It seems its not necessary to register an intr_handle for interrupt callback
function. "void* cb_arg" shows enough when be used to pass the object that
contain the information be required to handle the interrupt event( A typical
way which is implemented by almost all driver is by passing a rte_ethdev
instance).
The patch change the prototype of rte_intr_callback_fn by removing
the uncessary intr_handle paramter.

v7:

- Update for avp and tap driver which are new added
- Merge patch 2 and 3 of v6. 

v6:

- Sync with latest test code.

v5:

- Update mlx4 driver which is missed in previous version.

v4:

- Update mlx5 driver which is missed in v1, v2, v3.
- Add back patch 1 of v2 to make this complete though it already be applied.
- Remove patch 3 which is not necessary with latest master.

v3:
- Update bnx2x driver which is missed in v1,v2

v2:
- Seperate patch 1 in v1 into 2 patches.
- Correct some commit log.

*** BLURB HERE ***

Qi Zhang (2):
  vfio: keep interrupt source read only
  eal: clean up interrupt handle

 drivers/net/avp/avp_ethdev.c                   |  5 ++--
 drivers/net/bnx2x/bnx2x_ethdev.c               |  5 ++--
 drivers/net/bnxt/bnxt_irq.c                    |  3 +-
 drivers/net/e1000/em_ethdev.c                  |  8 ++----
 drivers/net/e1000/igb_ethdev.c                 | 15 ++++------
 drivers/net/enic/enic_main.c                   |  3 +-
 drivers/net/fm10k/fm10k_ethdev.c               | 12 +++-----
 drivers/net/i40e/i40e_ethdev.c                 |  8 ++----
 drivers/net/i40e/i40e_ethdev_vf.c              |  5 ++--
 drivers/net/ixgbe/ixgbe_ethdev.c               | 14 ++++-----
 drivers/net/mlx4/mlx4.c                        |  5 ++--
 drivers/net/mlx5/mlx5.h                        |  2 +-
 drivers/net/mlx5/mlx5_ethdev.c                 |  3 +-
 drivers/net/nfp/nfp_net.c                      |  6 ++--
 drivers/net/qede/qede_ethdev.c                 |  4 +--
 drivers/net/sfc/sfc_intr.c                     | 10 ++++---
 drivers/net/tap/rte_eth_tap.c                  |  3 +-
 drivers/net/virtio/virtio_ethdev.c             |  5 ++--
 drivers/net/virtio/virtio_ethdev.h             |  2 +-
 lib/librte_eal/common/include/rte_interrupts.h |  3 +-
 lib/librte_eal/linuxapp/eal/eal_alarm.c        |  5 ++--
 lib/librte_eal/linuxapp/eal/eal_interrupts.c   | 39 ++++----------------------
 test/test/test_interrupts.c                    | 23 +++++++--------
 23 files changed, 68 insertions(+), 120 deletions(-)

-- 
2.9.3



More information about the dev mailing list