[dpdk-dev] [PATCH 0/3] mk: fix LDLIBS
gage.eads at intel.com
Mon Oct 23 16:39:14 CEST 2017
> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Thursday, October 12, 2017 11:04 AM
> To: thomas at monjalon.net
> Cc: Eads, Gage <gage.eads at intel.com>; santosh.shukla at caviumnetworks.com;
> Richardson, Bruce <bruce.richardson at intel.com>;
> jerin.jacob at caviumnetworks.com; dev at dpdk.org
> Subject: [PATCH 0/3] mk: fix LDLIBS
> Some libraries in LDLIBS are currently generated from the
> DEPDIRS-$(dirname) variables in the Makefiles. This is valid when the
> subdirectory name match the library name, but it's not always the case,
> especially for PMDs.
> This series fixes some invalid dependency declarations first, and then removes
> the automatic generation of libraries from the directory names. Instead, the
> libraries are explicitly added in each Makefile.
These three patches look good. I tested it on the contrived example from my original email, and this appears to fix the issue.
Once the third patch's apply issues are resolved (http://dpdk.org/ml/archives/test-report/2017-October/032631.html):
Reviewed-by: Gage Eads <gage.eads at intel.com>
More information about the dev