[dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter

[Jerin Jacob]

-----Original Message-----
> Date: Tue, 3 Apr 2018 14:09:22 +0000
> From: "Carrillo, Erik G" <erik.g.carrillo at intel.com>
> To: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> CC: "dev at dpdk.org" <dev at dpdk.org>
> Subject: RE: [PATCH v9 0/9] eventtimer: introduce event timer adapter
> 
> Hi Jerin,


Hi Carrillo,

> 
> Question in-line:
> 
> > 1) Please fix following check-patch warnings:
> > 
> > ### eventtimer: introduce event timer adapter
> > 
> > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
> > #273: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:238:
> > +struct rte_event_timer_adapter * __rte_experimental
> > 
> > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
> > #303: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:268:
> > +struct rte_event_timer_adapter * __rte_experimenta
> > 
>  
> I was aware that checkpatch was complaining here, but the style I used is 
> consistent with almost all the existing DPDK code that uses the __rte_experimental
> tag.  Should I fix the warning if the style will differ from existing code?

Probably, We could fix the checkpatch. May be for short term we could
live with those warnings.

> 
> Thanks,
> Gabriel
>