[dpdk-dev] [PATCH v5 0/6] TAP RSS eBPF cover letter

[Ophir Munk]

Hi Ferruh,
Thanks for applying v5 patches while changing the order of commits and adding "Acked-by: ..."

I have sent v6 which does the same but also updates the commit messages of the switched commits to reflect more accurately the new order. 

Please let know if you are going to leave v5 as is or replace it with v6.

Regards,
Ophir

> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Saturday, January 20, 2018 6:16 PM
> To: Pascal Mazon <pascal.mazon at 6wind.com>; Ophir Munk
> <ophirmu at mellanox.com>; dev at dpdk.org
> Cc: Thomas Monjalon <thomas at monjalon.net>; Olga Shern
> <olgas at mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH v5 0/6] TAP RSS eBPF cover letter
> 
> On 1/19/2018 6:48 AM, Pascal Mazon wrote:
> > Hi,
> >
> > It seems more logical to me to introduce tap_program (patch 3) before
> > its compiled version (patch 2).
> > Source code is indeed written down before compiling it.
> >
> > The doc section is a good addition.
> > I'll be happy to see the upcoming utility for turning eBPF bytecode to
> > C arrays.
> > I'd have liked to see automation code (in a not-executed Makefile
> > target
> > typically) for generating the bytecode.
> > I'm being told it should happen in the upcoming series along with the
> > aforementioned utility.
> >
> > Otherwise code looks good enough (I couldn't see everything for lack
> > of time), considering that later patches are expected in next release.
> >
> > Acked-by: Pascal Mazon <pascal.mazon at 6wind.com>
> >
> > Best regards,
> > Pascal
> >
> > On 18/01/2018 14:38, Ophir Munk wrote:
> >> The patches of TAP RSS eBPF follow the RFC on this issue
> >>
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdp
> >>
> dk.org%2Fdev%2Fpatchwork%2Fpatch%2F31781%2F&data=02%7C01%7Cop
> hirmu%40
> >>
> mellanox.com%7Ccd9b412a6c1d428fe52308d56021141b%7Ca652971c7d2e
> 4d9ba6a
> >>
> 4d149256f461b%7C0%7C0%7C636520617565078480&sdata=7AuH4FxyKlZR
> %2Fwy6%2
> >> B3hEnW3UQIWmGonkq%2FtAxPdEG2w%3D&reserved=0
> >>
> >> v5 changes with respect to v4
> >> =============================
> >> Update TAP document guide with RSS
> >>
> >> v4 changes with respect to v3
> >> =============================
> >> * Code updates based on review comments
> >> * New commits organization (2-->5) based on review comments
> >>   1. net/tap: support actions for different classifiers (preparations for BPF.
> >>      No BPF code yet)
> >>   2. net/tap: add eBPF bytes code (BPF bytes code in a separate file)
> >>   3. net/tap: add eBPF program file (Program source code of bytes code)
> >>   4. net/tap: add eBPF API (BPF API to be used by TAP)
> >>   5. net/tap: implement TAP RSS using eBPF
> >>
> >> v3 changes with respect to v2
> >> =============================
> >> * Add support for IPv6 RSS in BPF program
> >> * Bug fixes
> >> * Updated compatibility to kernel versions:
> >>   eBPF requires Linux version 4.9 configured with BPF
> >> * New license header (SPDX) for newly added files
> >>
> >> v2 changes with respect to v1
> >> =============================
> >> * v2 has new commits organization (3 --> 2)
> >> * BPF program was revised. It is successfully tested on
> >>   IPv4 L3 L4 layers (compatible to mlx4 device)
> >> * Licensing: no comments received for using "Dual BSD/GPL"
> >>   string during BPF program loading to the kernel.
> >>   (v1 and v2 are using the same license strings)
> >>   Any comments are welcome.
> >> * Compatibility to kernel versions:
> >>   eBPF requires Linux version 4.2 configured with BPF. TAP PMD will
> >>   successfully compile on systems with old or non-BPF configured kernels.
> >>   During compilation time the required Linux headers are searched for.
> >>   If they are not present missing definitions are locally added
> >>   (tap_autoconf.h).
> >>   If the kernel cannot support a BPF operation - at runtime it will
> >>   gracefully reject the netlink message (with BPF) sent to it.
> >>
> >> Ophir Munk (6):
> >>   net/tap: support actions for different classifiers
> >>   net/tap: add eBPF bytes code
> >>   net/tap: add eBPF program file
> >>   net/tap: add eBPF API
> >>   net/tap: implement TAP RSS using eBPF
> >>   doc: detail new tap RSS feature in guides
> 
> Series applied to dpdk-next-net/master, thanks.