[dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const

Maxime Coquelin maxime.coquelin at redhat.com
Fri Mar 22 19:09:56 CET 2019



On 3/21/19 8:59 PM, Stephen Hemminger wrote:
> The divisor is not modified here. Doesn't really matter for optimizaton
> since the function is inline already; but helps with expressing
> intent.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>   lib/librte_eal/common/include/rte_reciprocal.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/common/include/rte_reciprocal.h b/lib/librte_eal/common/include/rte_reciprocal.h
> index 3492c73bafea..63e16fde0aa8 100644
> --- a/lib/librte_eal/common/include/rte_reciprocal.h
> +++ b/lib/librte_eal/common/include/rte_reciprocal.h
> @@ -77,7 +77,7 @@ mullhi_u64(uint64_t x, uint64_t y)
>   }
>   
>   static __rte_always_inline uint64_t
> -rte_reciprocal_divide_u64(uint64_t a, struct rte_reciprocal_u64 *R)
> +rte_reciprocal_divide_u64(uint64_t a, const struct rte_reciprocal_u64 *R)
>   {
>   	uint64_t t = mullhi_u64(a, R->m);
>   
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>


More information about the dev mailing list