[dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const

Thomas Monjalon thomas at monjalon.net
Wed Mar 27 12:14:44 CET 2019


21/03/2019 20:59, Stephen Hemminger:
> The divisor is not modified here. Doesn't really matter for optimizaton
> since the function is inline already; but helps with expressing
> intent.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  static __rte_always_inline uint64_t
> -rte_reciprocal_divide_u64(uint64_t a, struct rte_reciprocal_u64 *R)
> +rte_reciprocal_divide_u64(uint64_t a, const struct rte_reciprocal_u64 *R)

Why not doing the same change for rte_reciprocal_divide()?

Should we advertise such API change?




More information about the dev mailing list