[PATCH] net/gve: fix bug in verify driver compatibility

Ferruh Yigit ferruh.yigit at amd.com
Thu Jun 1 10:26:27 CEST 2023


On 6/1/2023 5:49 AM, Rushil Gupta wrote:
> gVNIC requires physical address to be passed in the adminq command.
> This was initially rightly pointed by ferruh.yigit at .
> Fixed by passing 'driver_info_mem->iova'.
> 
> Signed-off-by: Rushil Gupta <rushilg at google.com>
> ---
>  drivers/net/gve/gve_ethdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
> index 2c1e73d07a..aa75abe102 100644
> --- a/drivers/net/gve/gve_ethdev.c
> +++ b/drivers/net/gve/gve_ethdev.c
> @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv *priv)
>  			(char *)driver_info->os_version_str2);
>  
>  	err = gve_adminq_verify_driver_compatibility(priv,
> -		sizeof(struct gve_driver_info), (dma_addr_t)driver_info);
> +		sizeof(struct gve_driver_info),
> +		(dma_addr_t)driver_info_mem->iova);
>

Yep, this was my point, let me squashed onto original patch in next-net.




More information about the dev mailing list