[PATCH] net/gve: fix bug in verify driver compatibility

Guo, Junfeng junfeng.guo at intel.com
Thu Jun 1 10:58:10 CEST 2023



> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at amd.com>
> Sent: Thursday, June 1, 2023 16:35
> To: Guo, Junfeng <junfeng.guo at intel.com>; Rushil Gupta
> <rushilg at google.com>; Zhang, Qi Z <qi.z.zhang at intel.com>
> Cc: dev at dpdk.org
> Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility
> 
> On 6/1/2023 7:44 AM, Guo, Junfeng wrote:
> >
> >
> >> -----Original Message-----
> >> From: Rushil Gupta <rushilg at google.com>
> >> Sent: Thursday, June 1, 2023 12:50
> >> To: Zhang, Qi Z <qi.z.zhang at intel.com>; ferruh.yigit at amd.com
> >> Cc: Guo, Junfeng <junfeng.guo at intel.com>; dev at dpdk.org; Rushil
> Gupta
> >> <rushilg at google.com>
> >> Subject: [PATCH] net/gve: fix bug in verify driver compatibility
> >>
> >> gVNIC requires physical address to be passed in the adminq command.
> >> This was initially rightly pointed by ferruh.yigit at .
> >> Fixed by passing 'driver_info_mem->iova'.
> >
> > For bug fixing, it is required to reference the id of the commit which
> introduced the bug.
> > You can generate the required lines using the following git alias:
> > ''' git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h
> (\"%s\")%nCc: %ae'"  '''
> > and then put the output of ''' git fixline <SHA> ''' into the commit
> message.
> >
> > And also be CCed to the stable at dpdk.org mailing list. Thanks!
> >
> > Regards,
> > Junfeng
> >
> 
> Hi Junfeng,
> 
> You are right, but for this case patch is not pulled to main repo yet,
> and change is trivial, so I will fix it in next-net.

Sure, thanks for the efforts!


More information about the dev mailing list