[dts] [PATCH] tests/TestSuite_vlan_ethertype_config.py: Added condition check to selected "tpids" based on cards.

Tu, Lijuan lijuan.tu at intel.com
Wed Jun 26 09:08:14 CEST 2019


Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of thaq at marvell.com
> Sent: Monday, June 17, 2019 4:21 PM
> To: dts at dpdk.org
> Cc: fmasood at marvell.com; avijay at marvell.com; Thanseerulhaq
> <thaq at marvell.com>
> Subject: [dts] [PATCH] tests/TestSuite_vlan_ethertype_config.py: Added
> condition check to selected "tpids" based on cards.
> 
> From: Thanseerulhaq <thaq at marvell.com>
> 
> cavium_a063 cards supports only default tpids in rx mode so added
> conditon checks.
> Listing "test_vlan_qinq_tpid" & test_vlan_change_tpid testcase of
> vlan_ethertype_config as invalid for cavium_a063 cards.
> 
> Signed-off-by: Thanseerulhaq <thaq at marvell.com>
> ---
>  conf/test_case_checklist.json            | 16 ++++++++++++++++
>  tests/TestSuite_vlan_ethertype_config.py | 24 ++++++++++++++++++++----
>  2 files changed, 36 insertions(+), 4 deletions(-)
> 
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index 7b46bc1..1c4dc6d 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2103,6 +2103,7 @@
>                  "fortville_spirit_single",
>                  "cavium_a034",
>                  "cavium_a011",
> +                "cavium_a063"
>                  "fortville_25g"
>              ],
>              "Target": [
> @@ -2296,5 +2297,20 @@
>              "Bug ID": "",
>              "Comments": "the nic not support this case"
>          }
> +    ],
> +     "vlan_change_tpid": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "cavium_a063"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "the nic not support this case"
> +        }
>      ]
>  }
> diff --git a/tests/TestSuite_vlan_ethertype_config.py
> b/tests/TestSuite_vlan_ethertype_config.py
> index 684f68a..1cb1083 100644
> --- a/tests/TestSuite_vlan_ethertype_config.py
> +++ b/tests/TestSuite_vlan_ethertype_config.py
> @@ -198,7 +198,11 @@ class TestVlanEthertypeConfig(TestCase):
>          self.dut.send_expect("vlan set strip off %s" %
>                               dutRxPortId, "testpmd> ", 20)
>          rx_vlans = [1, random_vlan, MAX_VLAN]
> -        tpids = [0x8100, 0xA100]
> +        # caium_a063 card support only default '0x8100' tpid in rx mode
> +        if self.nic == "cavium_a063":
> +            tpids = [0x8100]
> +        else:
> +            tpids = [0x8100, 0xA100]
>          for tpid in tpids:
>              self.dut.send_expect("vlan set outer tpid 0x%x %s" %
>                                   (tpid, dutRxPortId), "testpmd> ") @@ -226,7 +230,11
> @@ class TestVlanEthertypeConfig(TestCase):
>                               dutRxPortId, "testpmd> ", 20)
>          self.dut.send_expect("start", "testpmd> ")
> 
> -        tpids = [0x8100, 0xA100]
> +        # caium_a063 card support only default '0x8100' tpid in rx mode
> +        if self.nic == "cavium_a063":
> +            tpids = [0x8100]
> +        else:
> +            tpids = [0x8100, 0xA100]
>          for tpid in tpids:
>              self.dut.send_expect("vlan set outer tpid 0x%x %s" %
>                                   (tpid, dutRxPortId), "testpmd> ") @@ -254,7 +262,11
> @@ class TestVlanEthertypeConfig(TestCase):
>              "vlan set strip on %s" % dutRxPortId, "testpmd> ", 20)
>          self.dut.send_expect("start", "testpmd> ", 20)
> 
> -        tpids = [0x8100, 0xA100]
> +        # caium_a063 card support only default '0x8100' tpid in rx mode
> +        if self.nic == "cavium_a063":
> +            tpids = [0x8100]
> +        else:
> +            tpids = [0x8100, 0xA100]
>          for tpid in tpids:
>              self.dut.send_expect("vlan set outer tpid 0x%x %s" %
>                                   (tpid, dutRxPortId), "testpmd> ") @@ -279,7 +291,11
> @@ class TestVlanEthertypeConfig(TestCase):
>                               dutRxPortId, "testpmd> ", 20)
>          self.dut.send_expect("start", "testpmd> ")
> 
> -        tpids = [0x8100, 0xA100]
> +        # caium_a063 card support only default '0x8100' tpid in rx mode
> +        if self.nic == "cavium_a063":
> +            tpids = [0x8100]
> +        else:
> +            tpids = [0x8100, 0xA100]
>          for tpid in tpids:
>              self.dut.send_expect("vlan set outer tpid 0x%x %s" %
>                                   (tpid, dutTxPortId), "testpmd> ")
> --
> 1.8.3.1



More information about the dts mailing list