[dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error
Fu, Qi
qi.fu at intel.com
Wed Jul 27 05:25:08 CEST 2022
Acked-by: Fu, Qi <qi.fu at intel.com>
> -----Original Message-----
> From: Xu, Ke1 <ke1.xu at intel.com>
> Sent: Thursday, July 21, 2022 2:13 PM
> To: dts at dpdk.org
> Cc: Fu, Qi <qi.fu at intel.com>; Xu, Ke1 <ke1.xu at intel.com>
> Subject: [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to
> fix a checksum-verify error
>
> Function "get_chksum_value_and_verify" in test suite TSO case
> test_tso_tunneling cannot verify checksum error.
>
> This function uses the auto checksum calculation of scapy by reading the pcap
> file, erasing the checksum and writing back to a new pcap file. Duplicated call to
> method "packet.read_pcapfile" at line 149 and line 162 will append extra
> packets to the packet sequence stored in "packet.pktgen.pkts". And erasing the
> checksum at line 153 to line 160 will modify the appended packets.
> This leads to a wrongly organized packet sequence writen to file at line 161,
> causing the checksum verifying wrongly use the raw checksum as the corrected
> checksum. This fails the following checksum verifying.
>
> By removing duplicated method call at line 149 and creating new object for
> temporary use at line 162. This bug is fixed.
>
> Signed-off-by: Ke Xu <ke1.xu at intel.com>
> ---
> tests/TestSuite_tso.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> 2.25.1
More information about the dts
mailing list