[dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the execution efficiency

[Fu, Qi]

Acked-by: Fu, Qi <qi.fu at intel.com>

> -----Original Message-----
> From: Xu, Ke1 <ke1.xu at intel.com>
> Sent: Thursday, July 21, 2022 2:13 PM
> To: dts at dpdk.org
> Cc: Fu, Qi <qi.fu at intel.com>; Xu, Ke1 <ke1.xu at intel.com>
> Subject: [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to
> improve the execution efficiency
> 
> Function "get_chksum_value_and_verify" in test suite TSO case
> test_tso_tunneling  is of low efficiency. Methods are wrongly used.
> 
> Duplicated call to method "packet.read_pcapfile" in this function will lengthen
> the packet sequence stored in "packet.pktgen.pkts", consuming more time when
> save pcap file. Duplicated call to method "packet.save_pcapfile" is also time
> consuming.
> 
> Method "pks.show" and "self.pks1[i].show" is not used as expected. "*.show" is
> used to print the packet object, not intended to return a string. Current code  is
> actually getting a method object and using "str(*)" method to turn a method
> object to a string, this may fail when "*.show" method is updated. The packet
> information printing here is equivilant to "repr(pks)".
> 
> Signed-off-by: Ke Xu <ke1.xu at intel.com>
> ---
>  tests/TestSuite_tso.py | 25 +++++++++++++++----------
>  1 file changed, 15 insertions(+), 10 deletions(-)
> 
> 2.25.1