[dpdk-stable] [dpdk-dev] [PATCH v7 8/9] ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
Yuanhan Liu
yuanhan.liu at linux.intel.com
Tue Sep 27 08:28:38 CEST 2016
On Thu, Sep 08, 2016 at 10:18:10PM +0530, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m at linux.vnet.ibm.com>
>
> This patch fixes ip_pipeline panic in app_init_core_map while preparing cpu
> core map in powerpc with SMT off. cpu_core_map_compute_linux currently prepares
> core mapping based on file existence in sysfs ie.
>
> /sys/devices/system/cpu/cpu<LCORE_NUM>/topology/physical_package_id
> /sys/devices/system/cpu/cpu<LCORE_NUM>/topology/core_id
>
> These files do not exist for lcores which are offline for any reason (as in
> powerpc, while SMT is off). In this situation, this function should further
> continue preparing map for other online lcores instead of returning with -1
> for a first unavailable lcore.
>
> Also, in SMT=off scenario for powerpc, lcore ids can not be always indexed from
> 0 upto 'number of cores present' (/sys/devices/system/cpu/present). For eg, for
> an online lcore 32, core_id returned in sysfs is 112 where online lcores are
> 10 (as in one configuration), hence sysfs lcore id can not be checked with
> indexing lcore number before positioning lcore map array.
>
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m at linux.vnet.ibm.com>
> Acked by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
> Acked-by: Chao Zhu <chaozhu at linux.vnet.ibm.com>
FYI, this patch has been applied to stable branch v16.07.
It hasn't been pushed to http://dpdk.org/browse/dpdk-stable/ yet.
It will be pushed if I get no objections in around TWO days. So
please shutout if you have objections.
Thanks.
--yliu
More information about the stable
mailing list