[dpdk-stable] patch 'examples/l2fwd-crypto: fix padding' has been queued to stable release 16.11.1
Yuanhan Liu
yuanhan.liu at linux.intel.com
Fri Feb 17 08:44:10 CET 2017
On Thu, Feb 16, 2017 at 09:10:16AM +0000, De Lara Guarch, Pablo wrote:
> Hi Yuanhan,
>
>
> > -----Original Message-----
> > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> > Sent: Thursday, February 16, 2017 8:02 AM
> > To: De Lara Guarch, Pablo
> > Cc: Zhang, Roy Fan; dpdk stable
> > Subject: Re: patch 'examples/l2fwd-crypto: fix padding' has been queued to
> > stable release 16.11.1
> >
> > It introduced a build error. I will drop it. If you think this patch
> > is still needed, please do the backport.
> >
> > examples/l2fwd-crypto/main.c: In function
> > ‘l2fwd_simple_crypto_enqueue’:
> > examples/l2fwd-crypto/main.c:467:8: error:
> > ‘RTE_CRYPTO_CIPHER_DES_CBC’ undeclared (first use in this function)
> > case RTE_CRYPTO_CIPHER_DES_CBC:
> > ^
> > compilation terminated due to -Wfatal-errors.
>
> This is why I didn't push it to the stable branch.
I see.
> I thought that fixes to sample apps were not needed.
I and Thomas had a such converstion before, and seems we both agree
that it's necessary to backport fixes for samples, for the reason
the user may still try with them.
> DES-CBC was introduced in 17.02, that's why there is a compilation issue.
>
> So, if this kind of fix can be pushed to the stable branch,
> I will do the backport (all that is required is removing that line).
If you, as the crypto maintainer, think it's needed, then I think you
could go for the backport :)
--yliu
More information about the stable
mailing list