[dpdk-stable] patch 'net/atlantic: remove unused variable' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Tue Apr 16 16:36:38 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/24/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From eacc1c58bccfdf849fd131c9d6ca3e94934cf383 Mon Sep 17 00:00:00 2001
From: Igor Russkikh <igor.russkikh at aquantia.com>
Date: Tue, 12 Mar 2019 15:24:53 +0000
Subject: [PATCH] net/atlantic: remove unused variable

[ upstream commit 1da02f4ebe1ddfaf9adbe0fdf43288b20596b43f ]

Found by coverity scan.

Coverity issue: 323512
Fixes: 7906661edac6 ("net/atlantic: add b0 hardware layer")

Signed-off-by: Igor Russkikh <igor.russkikh at aquantia.com>
---
 drivers/net/atlantic/hw_atl/hw_atl_b0.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/atlantic/hw_atl/hw_atl_b0.c
index 9400e0edb..53fd8e9f0 100644
--- a/drivers/net/atlantic/hw_atl/hw_atl_b0.c
+++ b/drivers/net/atlantic/hw_atl/hw_atl_b0.c
@@ -32,5 +32,4 @@ static int hw_atl_b0_hw_qos_set(struct aq_hw_s *self)
 	u32 buff_size = 0U;
 	unsigned int i_priority = 0U;
-	bool is_rx_flow_control = false;
 
 	/* TPS Descriptor rate init */
@@ -65,5 +64,4 @@ static int hw_atl_b0_hw_qos_set(struct aq_hw_s *self)
 	/* QoS Rx buf size per TC */
 	tc = 0;
-	is_rx_flow_control = 0;
 	buff_size = HW_ATL_B0_RXBUF_MAX;
 
@@ -77,7 +75,5 @@ static int hw_atl_b0_hw_qos_set(struct aq_hw_s *self)
 						   (1024U / 32U) * 50U) /
 						   100U, tc);
-	hw_atl_rpb_rx_xoff_en_per_tc_set(self,
-					 is_rx_flow_control ? 1U : 0U,
-					 tc);
+	hw_atl_rpb_rx_xoff_en_per_tc_set(self, 0U, tc);
 
 	/* QoS 802.1p priority -> TC mapping */
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-16 15:34:26.114964324 +0100
+++ 0020-net-atlantic-remove-unused-variable.patch	2019-04-16 15:34:25.164180305 +0100
@@ -1,13 +1,14 @@
-From 1da02f4ebe1ddfaf9adbe0fdf43288b20596b43f Mon Sep 17 00:00:00 2001
+From eacc1c58bccfdf849fd131c9d6ca3e94934cf383 Mon Sep 17 00:00:00 2001
 From: Igor Russkikh <igor.russkikh at aquantia.com>
 Date: Tue, 12 Mar 2019 15:24:53 +0000
 Subject: [PATCH] net/atlantic: remove unused variable
 
+[ upstream commit 1da02f4ebe1ddfaf9adbe0fdf43288b20596b43f ]
+
 Found by coverity scan.
 
 Coverity issue: 323512
 Fixes: 7906661edac6 ("net/atlantic: add b0 hardware layer")
-Cc: stable at dpdk.org
 
 Signed-off-by: Igor Russkikh <igor.russkikh at aquantia.com>
 ---


More information about the stable mailing list