[dpdk-stable] patch 'net/atlantic: remove extra checks for error codes' has been queued to LTS release 18.11.2

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/24/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From ea3d0a12a99272619620cc29d1a3143ae48b818c Mon Sep 17 00:00:00 2001
From: Igor Russkikh <igor.russkikh at aquantia.com>
Date: Tue, 12 Mar 2019 15:24:55 +0000
Subject: [PATCH] net/atlantic: remove extra checks for error codes

[ upstream commit 0b504bcfefc29fbafd9278603022093df401a85f ]

Found by Coverity scan. Checks are useless
because at these code places err is always zero.

Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations")

Signed-off-by: Igor Russkikh <igor.russkikh at aquantia.com>
---
 drivers/net/atlantic/hw_atl/hw_atl_utils.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
index f11093a50..13f02b9f9 100644
--- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c
+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
@@ -463,6 +463,4 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
 		}
 	} while (sw.tid != fw.tid || 0xFFFFU == fw.len);
-	if (err < 0)
-		goto err_exit;
 
 	if (rpc) {
@@ -876,6 +874,5 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac)
 
 	err = hw_atl_utils_fw_rpc_call(self, rpc_size);
-	if (err < 0)
-		goto err_exit;
+
 err_exit:
 	return err;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-16 15:34:26.154890011 +0100
+++ 0021-net-atlantic-remove-extra-checks-for-error-codes.patch	2019-04-16 15:34:25.165180283 +0100
@@ -1,13 +1,14 @@
-From 0b504bcfefc29fbafd9278603022093df401a85f Mon Sep 17 00:00:00 2001
+From ea3d0a12a99272619620cc29d1a3143ae48b818c Mon Sep 17 00:00:00 2001
 From: Igor Russkikh <igor.russkikh at aquantia.com>
 Date: Tue, 12 Mar 2019 15:24:55 +0000
 Subject: [PATCH] net/atlantic: remove extra checks for error codes
 
+[ upstream commit 0b504bcfefc29fbafd9278603022093df401a85f ]
+
 Found by Coverity scan. Checks are useless
 because at these code places err is always zero.
 
 Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations")
-Cc: stable at dpdk.org
 
 Signed-off-by: Igor Russkikh <igor.russkikh at aquantia.com>
 ---