[dpdk-stable] patch 'eal: explicit cast of strlcpy return' has been queued to LTS release 17.11.5
Yongseok Koh
yskoh at mellanox.com
Thu Jan 3 09:13:40 CET 2019
Hi,
FYI, your patch has been queued to LTS release 17.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/04/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.
Thanks.
Yongseok
---
>From 323afa8c5d4166c7591a4f6fad21535b2cede03d Mon Sep 17 00:00:00 2001
From: Andy Green <andy at warmcat.com>
Date: Thu, 17 May 2018 22:03:48 +0800
Subject: [PATCH] eal: explicit cast of strlcpy return
[ upstream commit 622a7305d1fd1e0150034b82ef92e62250befcd8 ]
GCC 8.1 warns:
rte_string_fns.h: In function 'rte_strlcpy':
rte_string_fns.h:58:9:
warning: conversion to 'size_t' {aka 'long unsigned int'} from
'int' may change the sign of the result [-Wsign-conversion]
return snprintf(dst, size, "%s", src);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 5d84a357fe57 ("eal: support strlcpy function")
Signed-off-by: Andy Green <andy at warmcat.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
lib/librte_eal/common/include/rte_string_fns.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/rte_string_fns.h b/lib/librte_eal/common/include/rte_string_fns.h
index 7c0ab15a3..7d57bb8ee 100644
--- a/lib/librte_eal/common/include/rte_string_fns.h
+++ b/lib/librte_eal/common/include/rte_string_fns.h
@@ -84,7 +84,7 @@ rte_strsplit(char *string, int stringlen,
static inline size_t
rte_strlcpy(char *dst, const char *src, size_t size)
{
- return snprintf(dst, size, "%s", src);
+ return (size_t)snprintf(dst, size, "%s", src);
}
/* pull in a strlcpy function */
--
2.11.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-01-02 23:59:13.000160826 -0800
+++ 0017-eal-explicit-cast-of-strlcpy-return.patch 2019-01-02 23:59:12.059819000 -0800
@@ -1,8 +1,10 @@
-From 622a7305d1fd1e0150034b82ef92e62250befcd8 Mon Sep 17 00:00:00 2001
+From 323afa8c5d4166c7591a4f6fad21535b2cede03d Mon Sep 17 00:00:00 2001
From: Andy Green <andy at warmcat.com>
Date: Thu, 17 May 2018 22:03:48 +0800
Subject: [PATCH] eal: explicit cast of strlcpy return
+[ upstream commit 622a7305d1fd1e0150034b82ef92e62250befcd8 ]
+
GCC 8.1 warns:
rte_string_fns.h: In function 'rte_strlcpy':
rte_string_fns.h:58:9:
@@ -11,7 +13,7 @@
return snprintf(dst, size, "%s", src);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-Fixes: 5364de644a4b ("eal: support strlcpy function")
+Fixes: 5d84a357fe57 ("eal: support strlcpy function")
Signed-off-by: Andy Green <andy at warmcat.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
@@ -20,10 +22,10 @@
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/rte_string_fns.h b/lib/librte_eal/common/include/rte_string_fns.h
-index fcbb42e00..97597a148 100644
+index 7c0ab15a3..7d57bb8ee 100644
--- a/lib/librte_eal/common/include/rte_string_fns.h
+++ b/lib/librte_eal/common/include/rte_string_fns.h
-@@ -55,7 +55,7 @@ rte_strsplit(char *string, int stringlen,
+@@ -84,7 +84,7 @@ rte_strsplit(char *string, int stringlen,
static inline size_t
rte_strlcpy(char *dst, const char *src, size_t size)
{
More information about the stable
mailing list