[dpdk-stable] patch 'eal: fix casts in random functions' has been queued to LTS release 17.11.5

[Yongseok Koh]

Hi,

FYI, your patch has been queued to LTS release 17.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Yongseok

---
>From 0088eb5cbe18679833d12fc38248d4f16b6d7120 Mon Sep 17 00:00:00 2001
From: Andy Green <andy at warmcat.com>
Date: Thu, 17 May 2018 21:49:12 +0800
Subject: [PATCH] eal: fix casts in random functions

[ upstream commit d3db77d7d88e1f9227c2847f3355fc3e4bd256e8 ]

GCC 8.1 warns:

In function 'rte_srand':
rte_random.h:34:10:
warning: conversion to 'long int' from 'long unsigned int'
may change the sign of the result [-Wsign-conversion]
  srand48((long unsigned int)seedval);

rte_random.h:51:8:
warning: conversion to 'uint64_t' {aka 'long unsigned int'}
from 'long int' may change the sign of the result
[-Wsign-conversion]
  val = lrand48();
        ^~~~~~~

rte_random.h:53:6:
warning: conversion to 'long unsigned int' from 'long int'
may change the sign of the result [-Wsign-conversion]
  val += lrand48();

Fixes: af75078fece3 ("first public release")

Signed-off-by: Andy Green <andy at warmcat.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 lib/librte_eal/common/include/rte_random.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/common/include/rte_random.h b/lib/librte_eal/common/include/rte_random.h
index aeff1f059..bfbfd13ac 100644
--- a/lib/librte_eal/common/include/rte_random.h
+++ b/lib/librte_eal/common/include/rte_random.h
@@ -60,7 +60,7 @@ extern "C" {
 static inline void
 rte_srand(uint64_t seedval)
 {
-	srand48((long unsigned int)seedval);
+	srand48((long)seedval);
 }
 
 /**
@@ -77,9 +77,9 @@ static inline uint64_t
 rte_rand(void)
 {
 	uint64_t val;
-	val = lrand48();
+	val = (uint64_t)lrand48();
 	val <<= 32;
-	val += lrand48();
+	val += (uint64_t)lrand48();
 	return val;
 }
 
-- 
2.11.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-02 23:59:13.048995665 -0800
+++ 0018-eal-fix-casts-in-random-functions.patch	2019-01-02 23:59:12.062815000 -0800
@@ -1,8 +1,10 @@
-From d3db77d7d88e1f9227c2847f3355fc3e4bd256e8 Mon Sep 17 00:00:00 2001
+From 0088eb5cbe18679833d12fc38248d4f16b6d7120 Mon Sep 17 00:00:00 2001
 From: Andy Green <andy at warmcat.com>
 Date: Thu, 17 May 2018 21:49:12 +0800
 Subject: [PATCH] eal: fix casts in random functions
 
+[ upstream commit d3db77d7d88e1f9227c2847f3355fc3e4bd256e8 ]
+
 GCC 8.1 warns:
 
 In function 'rte_srand':
@@ -24,7 +26,6 @@
   val += lrand48();
 
 Fixes: af75078fece3 ("first public release")
-Cc: stable at dpdk.org
 
 Signed-off-by: Andy Green <andy at warmcat.com>
 Acked-by: Bruce Richardson <bruce.richardson at intel.com>
@@ -33,10 +34,10 @@
  1 file changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/lib/librte_eal/common/include/rte_random.h b/lib/librte_eal/common/include/rte_random.h
-index 63bb28088..b2ca1c209 100644
+index aeff1f059..bfbfd13ac 100644
 --- a/lib/librte_eal/common/include/rte_random.h
 +++ b/lib/librte_eal/common/include/rte_random.h
-@@ -31,7 +31,7 @@ extern "C" {
+@@ -60,7 +60,7 @@ extern "C" {
  static inline void
  rte_srand(uint64_t seedval)
  {
@@ -45,7 +46,7 @@
  }
  
  /**
-@@ -48,9 +48,9 @@ static inline uint64_t
+@@ -77,9 +77,9 @@ static inline uint64_t
  rte_rand(void)
  {
  	uint64_t val;