[dpdk-stable] patch 'common/qat: remove check of valid firmware response' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Fri Jan 4 14:24:03 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/11/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From aba3a2b8920464eb98fd8f617b3dee4e02a1fa13 Mon Sep 17 00:00:00 2001
From: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
Date: Fri, 14 Dec 2018 12:19:30 +0100
Subject: [PATCH] common/qat: remove check of valid firmware response

[ upstream commit 8c41455e9e610385b826271798c0b532fd59054a ]

This reverts commit d09973f6c4df ("common/qat: fix for invalid
response from firmware") due to incorrectly reporting failures
on some older firmware versions.

Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware")

Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
Acked-by: Fiona Trahe <fiona.trahe at intel.com>
---
 drivers/common/qat/qat_qp.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c
index 79f6a01ba..ec7f2b309 100644
--- a/drivers/common/qat/qat_qp.c
+++ b/drivers/common/qat/qat_qp.c
@@ -635,5 +635,4 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)
 	uint32_t resp_counter = 0;
 	uint8_t *resp_msg;
-	uint8_t hdr_flags;
 
 	rx_queue = &(tmp_qp->rx_q);
@@ -641,15 +640,8 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)
 	head = rx_queue->head;
 	resp_msg = (uint8_t *)rx_queue->base_addr + rx_queue->head;
-	hdr_flags = ((struct icp_qat_fw_comn_resp_hdr *)resp_msg)->hdr_flags;
 
 	while (*(uint32_t *)resp_msg != ADF_RING_EMPTY_SIG &&
 			resp_counter != nb_ops) {
 
-		if (unlikely(!ICP_QAT_FW_COMN_VALID_FLAG_GET(hdr_flags))) {
-			/* Fatal firmware error */
-			QAT_LOG(ERR, "QAT Firmware returned invalid response");
-			return 0;
-		}
-
 		if (tmp_qp->service_type == QAT_SERVICE_SYMMETRIC)
 			qat_sym_process_response(ops, resp_msg);
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-04 13:23:07.958286953 +0000
+++ 0021-common-qat-remove-check-of-valid-firmware-response.patch	2019-01-04 13:23:07.000000000 +0000
@@ -1,14 +1,15 @@
-From 8c41455e9e610385b826271798c0b532fd59054a Mon Sep 17 00:00:00 2001
+From aba3a2b8920464eb98fd8f617b3dee4e02a1fa13 Mon Sep 17 00:00:00 2001
 From: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
 Date: Fri, 14 Dec 2018 12:19:30 +0100
 Subject: [PATCH] common/qat: remove check of valid firmware response
 
+[ upstream commit 8c41455e9e610385b826271798c0b532fd59054a ]
+
 This reverts commit d09973f6c4df ("common/qat: fix for invalid
 response from firmware") due to incorrectly reporting failures
 on some older firmware versions.
 
 Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware")
-Cc: stable at dpdk.org
 
 Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
 Acked-by: Fiona Trahe <fiona.trahe at intel.com>


More information about the stable mailing list