[dpdk-stable] patch 'compress/qat: fix return on building request error' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Fri Jan 4 14:24:04 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/11/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 5d50bb019b0010f472c8a9c07338705f9b31f1ac Mon Sep 17 00:00:00 2001
From: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
Date: Fri, 14 Dec 2018 12:19:31 +0100
Subject: [PATCH] compress/qat: fix return on building request error

[ upstream commit 652b59df06ccf554d4c39ab76f8b85cc003cf9b0 ]

This patch fixes error status which should be set inside
qat_comp_build_request function in case any errors are detected.
In these cases op.status is set to
RTE_COMP_OP_STATUS_INVALID_ARGS to help application debug.

Fixes: 1947bd18580b ("compress/qat: support scatter-gather buffers")

Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
Acked-by: Fiona Trahe <fiona.trahe at intel.com>
---
 drivers/compress/qat/qat_comp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c
index 27547428f..8a6fad06a 100644
--- a/drivers/compress/qat/qat_comp.c
+++ b/drivers/compress/qat/qat_comp.c
@@ -37,4 +37,5 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,
 				"operation requests, op (%p) is not a "
 				"stateless operation.", op);
+		op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 		return -EINVAL;
 	}
@@ -62,4 +63,5 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,
 		if (ret) {
 			QAT_DP_LOG(ERR, "QAT PMD Cannot fill source sgl array");
+			op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 			return ret;
 		}
@@ -72,4 +74,5 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,
 		if (ret) {
 			QAT_DP_LOG(ERR, "QAT PMD Cannot fill dest. sgl array");
+			op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 			return ret;
 		}
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-04 13:23:07.980659179 +0000
+++ 0022-compress-qat-fix-return-on-building-request-error.patch	2019-01-04 13:23:07.000000000 +0000
@@ -1,15 +1,16 @@
-From 652b59df06ccf554d4c39ab76f8b85cc003cf9b0 Mon Sep 17 00:00:00 2001
+From 5d50bb019b0010f472c8a9c07338705f9b31f1ac Mon Sep 17 00:00:00 2001
 From: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
 Date: Fri, 14 Dec 2018 12:19:31 +0100
 Subject: [PATCH] compress/qat: fix return on building request error
 
+[ upstream commit 652b59df06ccf554d4c39ab76f8b85cc003cf9b0 ]
+
 This patch fixes error status which should be set inside
 qat_comp_build_request function in case any errors are detected.
 In these cases op.status is set to
 RTE_COMP_OP_STATUS_INVALID_ARGS to help application debug.
 
 Fixes: 1947bd18580b ("compress/qat: support scatter-gather buffers")
-Cc: stable at dpdk.org
 
 Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
 Acked-by: Fiona Trahe <fiona.trahe at intel.com>


More information about the stable mailing list