[dpdk-stable] patch 'examples/ip_frag: remove Tx fast free offload flag' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Thu Sep 5 12:17:20 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/12/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/9fcd5f3deee26954f0c4b1dd6c3bbfad6f33d783

Thanks.

Kevin Traynor

---
>From 9fcd5f3deee26954f0c4b1dd6c3bbfad6f33d783 Mon Sep 17 00:00:00 2001
From: Sunil Kumar Kori <skori at marvell.com>
Date: Thu, 25 Jul 2019 13:54:10 +0530
Subject: [PATCH] examples/ip_frag: remove Tx fast free offload flag

[ upstream commit ed553e3db4a84af0ddac0d898476333d61adb93a ]

Application uses different pool to allocate direct and indirect
mbufs which are further spliced together to consturct a fragmented
packet and same is transmitted over the port which is configured
with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
must belong to the same pool. But constructed packet violates
the conditions.

So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
configuration.

Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads API")

Signed-off-by: Sunil Kumar Kori <skori at marvell.com>
Reviewed-by: Jerin Jacob <jerinj at marvell.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
---
 examples/ip_fragmentation/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index ed78f0dd8..68d40c19a 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -922,7 +922,4 @@ main(int argc, char **argv)
 		if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
 			n_tx_queue = MAX_TX_QUEUE_PER_PORT;
-		if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
-			local_port_conf.txmode.offloads |=
-				DEV_TX_OFFLOAD_MBUF_FAST_FREE;
 		ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
 					    &local_port_conf);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-09-05 10:36:48.749916533 +0100
+++ 0020-examples-ip_frag-remove-Tx-fast-free-offload-flag.patch	2019-09-05 10:36:47.515700403 +0100
@@ -1 +1 @@
-From ed553e3db4a84af0ddac0d898476333d61adb93a Mon Sep 17 00:00:00 2001
+From 9fcd5f3deee26954f0c4b1dd6c3bbfad6f33d783 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ed553e3db4a84af0ddac0d898476333d61adb93a ]
+
@@ -17 +18,0 @@
-Cc: stable at dpdk.org
@@ -27 +28 @@
-index 03be0c12e..324d60773 100644
+index ed78f0dd8..68d40c19a 100644
@@ -30 +31 @@
-@@ -940,7 +940,4 @@ main(int argc, char **argv)
+@@ -922,7 +922,4 @@ main(int argc, char **argv)


More information about the stable mailing list