[dpdk-stable] patch 'examples/ptpclient: fix delay request message' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Thu Sep 5 12:17:21 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/12/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/797ad03ba206449099ead390cb9a0bbb6f7361e9

Thanks.

Kevin Traynor

---
>From 797ad03ba206449099ead390cb9a0bbb6f7361e9 Mon Sep 17 00:00:00 2001
From: Harman Kalra <hkalra at marvell.com>
Date: Thu, 25 Jul 2019 14:24:43 +0000
Subject: [PATCH] examples/ptpclient: fix delay request message

[ upstream commit 376aa383e70ac3b66f4d7b6cc33d9971331a3915 ]

Observed an issue with the length and domain number of the
delay request message sent out by the client. Due to which delay
response from master was not received.

Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")

Signed-off-by: Harman Kalra <hkalra at marvell.com>
Reviewed-by: Jerin Jacob <jerinj at marvell.com>
---
 examples/ptpclient/ptpclient.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
index 82ae71c19..89f19cadb 100644
--- a/examples/ptpclient/ptpclient.c
+++ b/examples/ptpclient/ptpclient.c
@@ -234,5 +234,9 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)
 
 	/* Enable timesync timestamping for the Ethernet device */
-	rte_eth_timesync_enable(port);
+	retval = rte_eth_timesync_enable(port);
+	if (retval < 0) {
+		printf("Timesync enable failed: %d\n", retval);
+		return retval;
+	}
 
 	/* Enable RX in promiscuous mode for the Ethernet device. */
@@ -414,4 +418,7 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)
 		ptp_msg->delay_req.hdr.control = 1;
 		ptp_msg->delay_req.hdr.log_message_interval = 127;
+		ptp_msg->delay_req.hdr.message_length =
+			htons(sizeof(struct delay_req_msg));
+		ptp_msg->delay_req.hdr.domain_number = ptp_hdr->domain_number;
 
 		/* Set up clock id. */
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-09-05 10:36:48.809262245 +0100
+++ 0021-examples-ptpclient-fix-delay-request-message.patch	2019-09-05 10:36:47.516700379 +0100
@@ -1 +1 @@
-From 376aa383e70ac3b66f4d7b6cc33d9971331a3915 Mon Sep 17 00:00:00 2001
+From 797ad03ba206449099ead390cb9a0bbb6f7361e9 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 376aa383e70ac3b66f4d7b6cc33d9971331a3915 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 95b0c176e..31778fd95 100644
+index 82ae71c19..89f19cadb 100644


More information about the stable mailing list