[dpdk-stable] patch 'net/mlx5: fix link speed info when link is down' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Thu Sep 5 12:17:50 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/12/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/c11aabbcc556287815b9d35141d1dbcde0f31707

Thanks.

Kevin Traynor

---
>From c11aabbcc556287815b9d35141d1dbcde0f31707 Mon Sep 17 00:00:00 2001
From: Xiaoyu Min <jackmin at mellanox.com>
Date: Mon, 5 Aug 2019 16:02:03 +0800
Subject: [PATCH] net/mlx5: fix link speed info when link is down

[ upstream commit 6fd05da9efbd387d0f1fdd7824bc5298dff368fe ]

When the link is down, the link speed returned by ethtool is
UINT32_MAX and the link status is 0.

In this case, the DPDK ethdev link speed should be set to
ETH_SPEED_NUM_NONE.
Otherwise since link speed is non-zero but link status is zero, this
is an inconsistent situation and -EAGAIN is returned, which is not right.

Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")

Signed-off-by: Xiaoyu Min <jackmin at mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at mellanox.com>
---
 drivers/net/mlx5/mlx5_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index 6a5bef117..9c7fc6b44 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -731,5 +731,6 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev,
 		return ret;
 	}
-	dev_link.link_speed = ecmd->speed;
+	dev_link.link_speed = (ecmd->speed == UINT32_MAX) ? ETH_SPEED_NUM_NONE :
+							    ecmd->speed;
 	sc = ecmd->link_mode_masks[0] |
 		((uint64_t)ecmd->link_mode_masks[1] << 32);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-09-05 10:36:50.529123230 +0100
+++ 0050-net-mlx5-fix-link-speed-info-when-link-is-down.patch	2019-09-05 10:36:47.560699325 +0100
@@ -1 +1 @@
-From 6fd05da9efbd387d0f1fdd7824bc5298dff368fe Mon Sep 17 00:00:00 2001
+From c11aabbcc556287815b9d35141d1dbcde0f31707 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6fd05da9efbd387d0f1fdd7824bc5298dff368fe ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 9629cfb33..33a32fc2f 100644
+index 6a5bef117..9c7fc6b44 100644
@@ -27 +28 @@
-@@ -909,5 +909,6 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev,
+@@ -731,5 +731,6 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev,


More information about the stable mailing list