[dpdk-stable] patch 'app/testpmd: fix latency stats deinit on signal' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Thu Sep 5 12:17:51 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/12/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/62aa226ee8102543cbd8c6d354924aaf52aacfdb

Thanks.

Kevin Traynor

---
>From 62aa226ee8102543cbd8c6d354924aaf52aacfdb Mon Sep 17 00:00:00 2001
From: Amit Gupta <agupta3 at marvell.com>
Date: Wed, 7 Aug 2019 18:42:09 +0530
Subject: [PATCH] app/testpmd: fix latency stats deinit on signal

[ upstream commit 8b36297d15f90265b50fae211157dff573513359 ]

On receiving signal, testpmd showing warning as
"LATENCY_STATS: failed to remove Rx/Tx callback"
because rte_latencystats_uninit is called without
checking if latencystats is enabled or not.

After this fix, rte_latencystats_uninit will be
called only if latencystats is enabled.

Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation")

Signed-off-by: Amit Gupta <agupta3 at marvell.com>
Acked-by: Jerin Jacob <jerinj at marvell.com>
Tested-by: Jerin Jacob <jerinj at marvell.com>
---
 app/test-pmd/testpmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 41283b481..83b5e42a3 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3079,5 +3079,6 @@ signal_handler(int signum)
 #endif
 #ifdef RTE_LIBRTE_LATENCY_STATS
-		rte_latencystats_uninit();
+		if (latencystats_enabled != 0)
+			rte_latencystats_uninit();
 #endif
 		force_quit();
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-09-05 10:36:50.588290621 +0100
+++ 0051-app-testpmd-fix-latency-stats-deinit-on-signal.patch	2019-09-05 10:36:47.563699253 +0100
@@ -1 +1 @@
-From 8b36297d15f90265b50fae211157dff573513359 Mon Sep 17 00:00:00 2001
+From 62aa226ee8102543cbd8c6d354924aaf52aacfdb Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8b36297d15f90265b50fae211157dff573513359 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index a461cef18..e8e2a39b6 100644
+index 41283b481..83b5e42a3 100644
@@ -28 +29 @@
-@@ -3213,5 +3213,6 @@ signal_handler(int signum)
+@@ -3079,5 +3079,6 @@ signal_handler(int signum)


More information about the stable mailing list