[dpdk-stable] patch 'examples/packet_ordering: use proper exit method' has been queued to LTS release 18.11.10

Kevin Traynor ktraynor at redhat.com
Fri Aug 28 12:13:02 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/02/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/08e79f9cf4c987b0cb6a94dcf398c538d084ef1a

Thanks.

Kevin.

---
>From 08e79f9cf4c987b0cb6a94dcf398c538d084ef1a Mon Sep 17 00:00:00 2001
From: Sarosh Arif <sarosh.arif at emumba.com>
Date: Fri, 5 Jun 2020 16:48:28 +0500
Subject: [PATCH] examples/packet_ordering: use proper exit method

[ upstream commit d74fab8e7cc36acaf2abf83888809fd1e40c932a ]

rte_exit should be called when the application exits due to
invalid EAL or application arguments.

Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")

Signed-off-by: Sarosh Arif <sarosh.arif at emumba.com>
---
 examples/packet_ordering/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c
index 149bfdd02c..df64158847 100644
--- a/examples/packet_ordering/main.c
+++ b/examples/packet_ordering/main.c
@@ -622,5 +622,5 @@ main(int argc, char **argv)
 	ret = rte_eal_init(argc, argv);
 	if (ret < 0)
-		return -1;
+		rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n");
 
 	argc -= ret;
@@ -630,5 +630,5 @@ main(int argc, char **argv)
 	ret = parse_args(argc, argv);
 	if (ret < 0)
-		return -1;
+		rte_exit(EXIT_FAILURE, "Invalid packet_ordering arguments\n");
 
 	/* Check if we have enought cores */
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-08-28 11:03:26.779969729 +0100
+++ 0036-examples-packet_ordering-use-proper-exit-method.patch	2020-08-28 11:03:25.987955943 +0100
@@ -1 +1 @@
-From d74fab8e7cc36acaf2abf83888809fd1e40c932a Mon Sep 17 00:00:00 2001
+From 08e79f9cf4c987b0cb6a94dcf398c538d084ef1a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d74fab8e7cc36acaf2abf83888809fd1e40c932a ]
+
@@ -17 +19 @@
-index 5c654c11c6..b5fc6c54be 100644
+index 149bfdd02c..df64158847 100644
@@ -20 +22 @@
-@@ -673,5 +673,5 @@ main(int argc, char **argv)
+@@ -622,5 +622,5 @@ main(int argc, char **argv)
@@ -27 +29 @@
-@@ -681,5 +681,5 @@ main(int argc, char **argv)
+@@ -630,5 +630,5 @@ main(int argc, char **argv)



More information about the stable mailing list