[dpdk-stable] patch 'net/netvsc: fix crash during Tx' has been queued to LTS release 18.11.10

Kevin Traynor ktraynor at redhat.com
Fri Aug 28 12:13:03 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/02/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/5b3a3277091dcf4869111fcc0835d7f553ee28ae

Thanks.

Kevin.

---
>From 5b3a3277091dcf4869111fcc0835d7f553ee28ae Mon Sep 17 00:00:00 2001
From: Chas Williams <3chas3 at gmail.com>
Date: Wed, 29 Jul 2020 09:58:44 -0400
Subject: [PATCH] net/netvsc: fix crash during Tx

[ upstream commit aee76bb79b91e2f8bce0e9356bee23f6e52d0513 ]

Commit cc0251813277 ("net/netvsc: split send buffers from Tx
descriptors") changed the way that transmit descriptors are
allocated. They come from a single pool instead of being
individually attached to each mbuf. To find the IOVA, you need
to calculate the offset from the base of the pool.

Fixes: cc0251813277 ("net/netvsc: split send buffers from Tx descriptors")

Signed-off-by: Chas Williams <3chas3 at gmail.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/netvsc/hn_rxtx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
index d7940b8119..cdd44a76c3 100644
--- a/drivers/net/netvsc/hn_rxtx.c
+++ b/drivers/net/netvsc/hn_rxtx.c
@@ -1317,9 +1317,10 @@ static int hn_xmit_sg(struct hn_tx_queue *txq,
 
 	/* pass IOVA of rndis header in first segment */
-	addr = rte_malloc_virt2iova(txd->rndis_pkt);
+	addr = rte_malloc_virt2iova(txq->tx_rndis);
 	if (unlikely(addr == RTE_BAD_IOVA)) {
 		PMD_DRV_LOG(ERR, "RNDIS transmit can not get iova");
 		return -EINVAL;
 	}
+	addr = addr + ((char *)txd->rndis_pkt - (char *)txq->tx_rndis);
 
 	sg[0].page = addr / PAGE_SIZE;
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-08-28 11:03:26.798811284 +0100
+++ 0037-net-netvsc-fix-crash-during-Tx.patch	2020-08-28 11:03:25.988955951 +0100
@@ -1 +1 @@
-From aee76bb79b91e2f8bce0e9356bee23f6e52d0513 Mon Sep 17 00:00:00 2001
+From 5b3a3277091dcf4869111fcc0835d7f553ee28ae Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit aee76bb79b91e2f8bce0e9356bee23f6e52d0513 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 86a4c0d741..0428c586a8 100644
+index d7940b8119..cdd44a76c3 100644
@@ -25 +26 @@
-@@ -1422,9 +1422,10 @@ static int hn_xmit_sg(struct hn_tx_queue *txq,
+@@ -1317,9 +1317,10 @@ static int hn_xmit_sg(struct hn_tx_queue *txq,



More information about the stable mailing list