patch 'cryptodev: fix RSA key type name' has been queued to stable release 20.11.5

[Ray Kinsella]

David Marchand <david.marchand at redhat.com> writes:

> Hello Luca, Kevin, Christian,
>
> On Mon, Feb 28, 2022 at 10:21 PM <luca.boccassi at gmail.com> wrote:
>> Subject: [PATCH] cryptodev: fix RSA key type name
>>
>> [ upstream commit 3387912f5cacd934594f2c7a0c34eda7279419a8 ]
>>
>> This patch fixes misspelled RTE_RSA_KEY_TYPE_QT,
>> this will prevent checkpach from complaining wherever
>> change to RSA is being made.
>>
>> Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions")
>>
>> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal at intel.com>
>> Acked-by: Akhil Goyal <gakhil at marvell.com>
>
> This patch triggers a warning from libabigail in UNH tests for 20.11 and 21.11:
>
>                                                   type of 'anonymous
> data member union {rte_crypto_rsa_xform rsa; rte_crypto_modex_xform
> modex; rte_crypto_modinv_xform modinv; rte_crypto_dh_xform dh;
> rte_crypto_dsa_xform dsa; rte_crypto_ec_xform ec;}' changed:
>                                                     type size hasn't changed
>                                                     1 data member change:
>                                                       type of
> 'rte_crypto_rsa_xform rsa' changed:
>                                                         type size hasn't changed
>                                                         1 data member change:
>                                                           type of
> 'rte_crypto_rsa_priv_key_type key_type' changed:
>                                                             type size
> hasn't changed
>                                                             1
> enumerator deletion:
>
> 'rte_crypto_rsa_priv_key_type::RTE_RSA_KET_TYPE_QT' value '1'
>                                                             1
> enumerator insertion:
>
> 'rte_crypto_rsa_priv_key_type::RTE_RSA_KEY_TYPE_QT' value '1'
>                                     type size hasn't changed
>
> Error: ABI issue reported for 'abidiff --suppr
> dpdk/devtools/libabigail.abignore --no-added-syms --headers-dir1
> reference/include --headers-dir2 build_install/include
> reference/dump/librte_ipsec.dump build_install/dump/librte_ipsec.dump'
>
> ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged
> this as a potential issue).
>
> This API is experimental, so changes are acceptable, but we are
> missing a suppression rule similar to what is in the main repo:
>
> ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental
> [suppress_type]
>         name = rte_crypto_asym_op
>
>
> Note to Thomas and myself: the next time we clean those rules, the
> suppression rule on asymmetric crypto should be kept if still
> experimental.

Might be worth adding a comment to that effect in libabigail, lest we
forget.


-- 
Regards, Ray K