[PATCH V2 2/4] net/bonding: fix non-terminable while loop
Min Hu (Connor)
humin29 at huawei.com
Thu Mar 24 04:00:34 CET 2022
From: Huisong Li <lihuisong at huawei.com>
All slaves will be stopped and removed when closing a bonded port. But the
while loop can not stop if both rte_eth_dev_stop and
rte_eth_bond_slave_remove fail to run.
Fixes: fb0379bc5db3 ("net/bonding: check stop call status")
Cc: stable at dpdk.org
Signed-off-by: Huisong Li <lihuisong at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 469dc71170..00d4deda44 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2149,13 +2149,14 @@ bond_ethdev_close(struct rte_eth_dev *dev)
return 0;
RTE_BOND_LOG(INFO, "Closing bonded device %s", dev->device->name);
- while (internals->slave_count != skipped) {
+ while (skipped < internals->slave_count) {
uint16_t port_id = internals->slaves[skipped].port_id;
if (rte_eth_dev_stop(port_id) != 0) {
RTE_BOND_LOG(ERR, "Failed to stop device on port %u",
port_id);
skipped++;
+ continue;
}
if (rte_eth_bond_slave_remove(bond_port_id, port_id) != 0) {
--
2.33.0
More information about the stable
mailing list