patch 'net/txgbe: fix Rx buffer size in config register' has been queued to stable release 22.11.2

Xueming Li xuemingl at nvidia.com
Mon Feb 27 08:00:25 CET 2023


Hi,

FYI, your patch has been queued to stable release 22.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/01/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=a93bb50b6c95b0b202df23f9eb263d6edf9436d4

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From a93bb50b6c95b0b202df23f9eb263d6edf9436d4 Mon Sep 17 00:00:00 2001
From: Jiawen Wu <jiawenwu at trustnetic.com>
Date: Wed, 15 Feb 2023 10:00:56 +0800
Subject: [PATCH] net/txgbe: fix Rx buffer size in config register
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 8a3ef4b89e6dd0247355fdf3a77ff7ec1db28d8d ]

When round up buffer size to 1K, to configure the register, hardware
will receive packets exceeding the buffer size in LRO mode. It will
cause a segment fault in the receive function.

Fixes: be797cbf4582 ("net/txgbe: add Rx and Tx init")

Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
---
 drivers/net/txgbe/txgbe_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c
index 021f281fbb..427f8b82ac 100644
--- a/drivers/net/txgbe/txgbe_rxtx.c
+++ b/drivers/net/txgbe/txgbe_rxtx.c
@@ -4392,7 +4392,7 @@ txgbe_dev_rx_init(struct rte_eth_dev *dev)
 		 */
 		buf_size = (uint16_t)(rte_pktmbuf_data_room_size(rxq->mb_pool) -
 			RTE_PKTMBUF_HEADROOM);
-		buf_size = ROUND_UP(buf_size, 0x1 << 10);
+		buf_size = ROUND_DOWN(buf_size, 0x1 << 10);
 		srrctl |= TXGBE_RXCFG_PKTLEN(buf_size);

 		wr32(hw, TXGBE_RXCFG(rxq->reg_idx), srrctl);
--
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-27 14:08:44.656228000 +0800
+++ 0118-net-txgbe-fix-Rx-buffer-size-in-config-register.patch	2023-02-27 14:08:40.869237000 +0800
@@ -1 +1 @@
-From 8a3ef4b89e6dd0247355fdf3a77ff7ec1db28d8d Mon Sep 17 00:00:00 2001
+From a93bb50b6c95b0b202df23f9eb263d6edf9436d4 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 8a3ef4b89e6dd0247355fdf3a77ff7ec1db28d8d ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list