[PATCH v2] net/vmxnet3: fix return code in initializing

Stephen Hemminger stephen at networkplumber.org
Tue Jun 6 17:36:12 CEST 2023


On Fri,  2 Jun 2023 12:44:38 -0400
Kaijun Zeng <corezeng at gmail.com> wrote:

> +				PMD_INIT_LOG(ERR,
> +					"ERROR: Zero descriptor requirement in Rx queue: %d,"
> +					"buffers ring: %d\n",
> +					i, j);

Please don't split messages across source lines, it makes harder for developers
to use tools to scan source for message.

Often, when message is long, it means that there is redundant information or poor wording.
For example, in your message "ERROR:" is redundant.


More information about the stable mailing list