[PATCH v2] net/vmxnet3: fix return code in initializing
Ferruh Yigit
ferruh.yigit at amd.com
Wed Jun 7 17:49:48 CEST 2023
On 6/6/2023 4:36 PM, Stephen Hemminger wrote:
> On Fri, 2 Jun 2023 12:44:38 -0400
> Kaijun Zeng <corezeng at gmail.com> wrote:
>
>> + PMD_INIT_LOG(ERR,
>> + "ERROR: Zero descriptor requirement in Rx queue: %d,"
>> + "buffers ring: %d\n",
>> + i, j);
>
> Please don't split messages across source lines, it makes harder for developers
> to use tools to scan source for message.
>
> Often, when message is long, it means that there is redundant information or poor wording.
> For example, in your message "ERROR:" is redundant.
>
Agree that 'ERROR:' is redundant, and +1 to not split log message.
Kaijun,
Would you mind sending a new version with above changes?
Thanks,
ferruh
More information about the stable
mailing list