Bug 1088 - [20.11] meson compatibility regression
Summary: [20.11] meson compatibility regression
Status: UNCONFIRMED
Alias: None
Product: DPDK
Classification: Unclassified
Component: meson (show other bugs)
Version: 20.11
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: dev
URL:
Depends on:
Blocks:
 
Reported: 2022-09-30 11:57 CEST by Kevin Traynor
Modified: 2023-03-14 09:27 CET (History)
2 users (show)



Attachments

Description Kevin Traynor 2022-09-30 11:57:53 CEST
DPDK 20.11 supports meson 0.47.1 as per:
http://doc.dpdk.org/guides-20.11/prog_guide/build-sdk-meson.html#getting-the-tools

The compatibility was found to be broken by the OVS CI when attempting to upgrade OVS to use 20.11.6 and reported here:
https://mail.openvswitch.org/pipermail/ovs-dev/2022-September/397953.html

David ID'd and reported the following commit as the offender:

commit 14421740c492df1d9267892566ef33e784790c1c
Author: Bruce Richardson <bruce.richardson@intel.com>
Date:   Thu Jan 20 18:06:39 2022 +0000

    build: fix warnings when running external commands
    
    [ upstream commit ecb904cc4596b33aa182e2a7c9edc3104ff981c3 ]
    
    Meson 0.61.1 is giving warnings that the calls to run_command do not
    always explicitly specify if the result is to be checked or not, i.e.
    there is a missing "check" parameter. This is because the default
    behaviour without the parameter is due to change in the future.
    
    We can fix these warnings by explicitly adding into each call whether
    the result should be checked by meson or not. This patch therefore
    adds in "check: false" to each run_command call where the result is
    being checked by the DPDK meson.build code afterwards, and adds in
    "check: true" to any calls where the result is currently unchecked.
    
    Bugzilla ID: 921
    
    Reported-by: Jerin Jacob <jerinj@marvell.com>
    Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
    Tested-by: Jerin Jacob <jerinj@marvell.com>
Comment 1 Kevin Traynor 2022-09-30 12:06:59 CEST
David and Thomas have setup a mirror of the dpdk-stable repo in github (thank you!) so this issue also looks to be tested and reported here:
https://github.com/DPDK/dpdk-stable/actions/runs/3113587297
Comment 2 Luca Boccassi 2022-09-30 12:08:10 CEST
Ok, I'll revert that change in the next version
Comment 3 David Marchand 2023-03-14 09:27:34 CET
Is there anything pending on this topic?

Note You need to log in before you can comment on or make changes to this bug.