Hi enic maintainers, With openvswitch 2.15 using dpdk 20.11.6, enic driver is reporting that it cannot accept setup with default OVS number of tx descriptors (2048). 2022-08-19T16:29:38.555Z|00204|dpdk|ERR|Invalid value for nb_tx_desc(=2048), should be: <= 256, >= 64, and a product of 32 OVS has used 2048 as default for many years and the code in 20.11.6 does not look like it changed much from previous releases either. The commit below [0] on dpdk main branch (but not on 20.11 branch), changes how max descriptor values are calculated. So any idea why the 2048 can no longer be used with 20.11.6 ? some commit I missed? different firmware? or is it an incorrect calculation and the commit [0] is needed on stable branches to correct this? Thanks. Reference: https://bugzilla.redhat.com/show_bug.cgi?id=2119876 [0] commit 22572e84fbda2c195707ffbb0dd6af4433d7a219 Author: John Daley <johndale@cisco.com> Date: Fri Jan 28 09:58:13 2022 -0800 net/enic: support max descriptors allowed by adapter Newer VIC adapters have the max number of supported RX and TX descriptors in their configuration. Use these values as the maximums. Signed-off-by: John Daley <johndale@cisco.com> Reviewed-by: Hyong Youb Kim <hyonkim@cisco.com>
Calculations done here, note differences between dpdk main using max_tq_ring/max_rq_ring sizes and 20.11 branch not using them. https://git.dpdk.org/dpdk-stable/tree/drivers/net/enic/enic_res.c?h=20.11#n103 https://git.dpdk.org/dpdk/tree/drivers/net/enic/enic_res.c#n113